[avrabe]

Refs #468. Fixes a regression that REQ-196 (#469) silently missed.

What I found (dogfooding the real export)

Building the current binary and running the actual rivet export --format html (then scanning all 988 pages) showed the perpetual <p class="aadl-loading">Loading AADL diagram...</p> placeholder still shipping in 2 pages — documents/ARCH-001.html (the exact page from #468) and artifacts/ARCH-SYS-001.html — with no honest fallback.

Root cause: REQ-196 patched the wrong function

REQ-196 added static_aadl_fallback inside rivet_core::export::render_document_body_for_export. But rivet export --format html is implemented by cmd_export_html in rivet-cli, which renders pages via the rivet-cli render/ serve renderers and wraps them in a wrap_page layout — it never calls the rivet-core function REQ-196 patched. So REQ-196 was effectively a no-op for the real export (and the published compliance report) — yet it was marked implemented on a unit test of the helper, not an end-to-end export check. (Lesson logged: verify acceptance against real output, not a helper unit test.)

Fix

Apply the placeholder → honest-note replacement in wrap_page, the universal per-page wrapper in cmd_export_html, so every exported page is covered regardless of which renderer produced it.

before:  raw "Loading AADL diagram..." pages: 2, honest-fallback pages: 0
after:   raw "Loading AADL diagram..." pages: 0, honest-fallback pages: present

Test

export_html_replaces_perpetual_aadl_loading_placeholder walks the full export output and asserts zero pages contain the raw placeholder — an end-to-end assertion (the gap that let REQ-196 slip through).

Verification

cargo test -p rivet-cli --test export_html … (pass) · fmt --check clean · clippy --all-targets -- -D warnings exit 0 · rivet validate PASS. Manually confirmed the real export now has 0 raw placeholders. Implements + Verifies REQ-200.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

📐 Rivet artifact delta

Change	Count
Added	1
Removed	0
Modified	0
Downstream impacted (depth ≤ 5)	0

Graph

graph LR
  REQ_200["REQ-200"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3

Loading

Added

• REQ-200

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-473 — download from the workflow run.

_{Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.}

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: bc4f900	Previous: 448f4db	Ratio
link_graph_build/10000	37109658 ns/iter (± 3060870)	27364774 ns/iter (± 142273)	1.36
traceability_matrix/1000	59925 ns/iter (± 374)	43392 ns/iter (± 258)	1.38
query/10000	325983 ns/iter (± 2267)	229838 ns/iter (± 5303)	1.42

This comment was automatically generated by workflow using github-action-benchmark.