Repository navigation
Fix travis build - #65
Merged
Merged
Conversation
… to fix test errors.
…tead. * Added semicolon to line where nothing was being returned in runtime.rs * Removed `async` from function where there was no `await` in subscribe_loop.rs * Refactored assertion in subscription.rs to make clippy happy.
…e_loop.rs since clippy was too aggressive in requiring its removal.
… `broken_intra_doc_links` and newer ones use `rustdoc::broken_intra_doc_links`, so the build fails on one or the other, so allowing unknown lints for now.
…t Clippy insists it isn't.
…oken_intra_doc_links`
…broken_intra_doc_links` * More fixing of unnecessary semicolons
…e...that is immediately dereferenced by the compiler"
… lints when Rust 1.59.0 becomes minimum version.
phairow
approved these changes
Feb 25, 2022
phairow
left a comment
phairow
left a comment
There was a problem hiding this comment.
LGTM! I had some questions since I am new to rust but it looks good overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made changes to fix the linter/Clippy errors, as well as formatter errors that were causing the build to fail. Important to note: