Repository navigation
Warn when explicitly configured filesystem paths are unusable - #3833
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
Startup now checks path.procfs, path.sysfs, path.rootfs, and path.udev.data only when the user sets them. A missing, non-directory, unreadable, or obviously wrong procfs/sysfs path is logged and the exporter continues. Fixes prometheus#3832 Signed-off-by: 玉升 <wyshdiy@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn at startup when a filesystem path the user explicitly configured is missing, not a directory, unreadable, or clearly not procfs/sysfs.
Default
--path.procfs,--path.sysfs,--path.rootfs, and--path.udev.datavalues are not checked. The exporter still starts after a warning so an unusual environment is not rejected.Fixes #3832
/cc @SuperQ @discordianfish