Repository navigation
Conversation
HLSLTokenizer::Next copied identifiers into the fixed-size m_identifier buffer without checking their length. Report an error and stop tokenizing instead, as the #line file name already does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLSLTokenizer::Nextcopies each identifier intom_identifier(s_maxIdentifier, 256 bytes) without checking its length, so a preset shader with an identifier longer than 255 characters writes past the buffer.This reports a syntax error and ends the token stream instead, matching how the
#linefile name is already bounded.Checked with AddressSanitizer on a small harness around the tokenizer: the overflow reproduces on master and is gone with this change.
As discussed with @kblaschke, this should also be cherry-picked to v4.1.x.