System tests: Archive fieldcompare diff files on failure - #740
Merged
MakisH merged 8 commits intoMay 14, 2026
Merged
Conversation
MakisH
added
GSoC
PranjalManhgaye
changed the title
PranjalManhgaye
changed the title
PranjalManhgaye
force-pushed
the
issue-441-archive-fieldcompare-diffs
branch
from
March 7, 2026 07:05
44fb3ea to
a904f4f
Compare
Collaborator
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6 |
2 tasks
MakisH
changed the title
MakisH
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds automatic archiving of fieldcompare-generated VTK diff files into a dedicated folder to make CI artifact debugging easier when comparisons fail.
Changes:
- Add logic to collect and copy
*diff*.(vtu|vtk|vtp)files intodiff-results/when fieldcompare fails. - Invoke the archiving step during systemtest failure handling.
- Document the new
diff-results/behavior in the systemtests README and add a changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tools/tests/systemtests/Systemtest.py | Copies fieldcompare diff VTK files into diff-results/ on fieldcompare failure. |
| tools/tests/README.md | Documents where to find diff VTK files in CI artifacts for debugging. |
| changelog-entries/441.md | Notes the user-facing behavior change for archiving diff files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@PranjalManhgaye could you please have a look at the copilot comments in this PR? |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Move DIFF_RESULTS_DIR below imports; archive with rglob and preserve precice-exports/ paths under diff-results/; lazy debug log once after copy; README clarifies archiving only runs on fieldcompare failure.
Collaborator
Author
|
yea i pushed an update that should cover the Copilot points (recursive copy under precice-exports/, paths preserved under diff-results/, README only on failure, constant + logging tidy‑ups) , could you take another look when you have time , thanks |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
MakisH
approved these changes
May 14, 2026
MakisH
left a comment
MakisH
left a comment
Member
There was a problem hiding this comment.
I tested this locally, and it works as expected. Thanks!
mike-tree-corvid
pushed a commit
to mike-tree-corvid/tutorials
that referenced
this pull request
Jun 12, 2026
github-project-automation
Bot
moved this to Planned next
in GSoC 2026: System tests improvements
github-project-automation
Bot
moved this from Planned next
to Done
in GSoC 2026: System tests improvements
MakisH
moved this from Done
to Before coding period
in GSoC 2026: System tests improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #441: archive fieldcompare diff VTK files so they are easy to find in CI artifacts when a comparison fails.
Changes
*diff*.vtu,*diff*.vtk, and*diff*.vtpfiles from precice-exports/ into adiff-results/folder in the same run directory.diff-results/for inspection (e.g. in ParaView) when debugging comparison failures.Checklist