Ogury Bid Adapter: repair a site.page that is not an absolute URL - #15630
Open
RemyLespagnol wants to merge 2 commits into
Open
RemyLespagnol wants to merge 2 commits into
RemyLespagnol wants to merge 2 commits into
Conversation
Barecheck - Code coverage reportTotal: 91.38%Your code coverage diff: 0.01% ▴ ✅ All code changes are covered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
#15480 removed the adapter's
site.pageoverride, so the adapter now forwards whatever the publisher's wrapper put inortb2.site.page. Some wrappers set that field to a bare hostname (www.example.com) rather than an absolute URL. Such a value has no resolvable origin and no page path, and our endpoint rejects the request.resolveSitePage()falls back torefererInfo.pagewhensite.pagecarries nohttp/httpsscheme, and leaves every absolute URL untouched. It reads nothing from the top window, so the cross-originSecurityErrorthat #15480 fixed cannot come back —should resolve site.page without any top-window location readlocks that in.onBidTimeoutresolves the page the same way, so timeout monitoring reports the URL the bid request actually carried.Adapter version bumped to 2.1.2.
Other information
Follow-up to #15480.