Remove monkey patch from Addressable::URI#normalized_query so that it can be compatible with Addressable 2.8.2#50
Open
ericfirth wants to merge 1 commit into
Conversation
… can be compatible with Addressable 2.8.2
jemminger
pushed a commit
to jemminger/postrank-uri
that referenced
this pull request
Mar 12, 2026
…ibility Remove the Addressable::URI#normalized_query monkey-patch that is incompatible with addressable 2.8+. Instead, handle whitespace in URIs by splitting on spaces in the normalize method. Based on PR postrank-labs#50 by @ericboehs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error on #49
Removing the monkey patch entirely lead to the following error
So I split on whitespace and took the first item. I initially tried just stripping the URI as a string, but then got
Happy to make any changes needed.