feat: add a force_ipv4 option to keep requests on IPv4 - #531
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
Some networks stall on IPv6 DNS or routing, the same problem youtube-dl and streamlink work around with a force-ipv4 switch. This adds a force_ipv4 option to gTTS and a matching --force-ipv4 CLI flag that mounts a requests adapter which keeps every connection on IPv4. It is off by default, so nothing changes unless you ask for it. Closes pndurette#310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310.
On some networks the request stalls trying IPv6 before it falls back to IPv4, which is the same thing youtube-dl and streamlink added a force-ipv4 switch for. This adds an optional
force_ipv4argument togTTSand a matching--force-ipv4flag on the CLI.When it's set, the request mounts a small adapter that keeps every connection on IPv4. It's off by default so nothing changes unless you ask for it. I added tests for both the Python and CLI paths (they run offline against a local server).