Revise pull request template for Aurora - #158
Merged
Merged
Conversation
stevepiercy
marked this pull request as ready for review
July 30, 2026 20:41
stevepiercy
commented
Jul 30, 2026
| - [ ] I verified there aren't other open [pull requests](https://github.com/plone/aurora/pulls) for the same change. | ||
| - [ ] I followed the guidelines in [Contributing to Aurora](https://plone-aurora.readthedocs.io/contributing/index.html). | ||
| - [ ] I succesfully ran [code linting checks](https://plone-aurora.readthedocs.io/contributing/linting.html) on my changes locally. | ||
| - [ ] I succesfully ran [unit tests](#) on my changes locally. [There is no link for this. @sneridagh] |
Collaborator
There was a problem hiding this comment.
@stevepiercy Added the testing page and moved your news entry in the apps/aurora folder (it was in the obsolete packages/volto folder)
stevepiercy
commented
Jul 30, 2026
stevepiercy
left a comment
stevepiercy
left a comment
Member
Author
There was a problem hiding this comment.
@sneridagh @pnicolli help!
pnicolli
approved these changes
Sep 25, 2026
stevepiercy
commented
Sep 26, 2026
stevepiercy
left a comment
stevepiercy
left a comment
Member
Author
There was a problem hiding this comment.
This looks really good. I have only a few suggestions.
Oh, I can only Comment, not Request changes, but you know how to work with that.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #151 (comment)