Repository navigation
chore(site): bump next to 16.3.8 and refresh vulnerable transitive deps - #28
Open
KaranjotVendal wants to merge 1 commit into
Open
KaranjotVendal wants to merge 1 commit into
KaranjotVendal wants to merge 1 commit into
Conversation
Fixes 15 of 16 pnpm audit findings on the docs site: - next 16.3.5 -> 16.3.8: RCE in next/og ImageResponse (GHSA-vcvr-r3jv-pc5j, critical), SSRF in Image Optimization (GHSA-cjq9-62q9-8jv4), Draft Mode cache leak (GHSA-3w37-wq28-93x7), two SSG/ISR cache-poisoning issues (GHSA-4jqv-mc3x-m676, GHSA-mcj8-r9mp-w47p), App Router metadata image disclosure (GHSA-f87g-xv8r-7p7x), dev-server MCP info disclosure (GHSA-39w2-rjm5-chcv) - transitive refreshes within semver ranges: sharp >=0.35.5 (librsvg, GHSA-wq5f-xc86-pv6w), source-map-js >=1.2.2 (GHSA-68fv-2mgg-jv7q), brace-expansion (GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7p, GHSA-q2hr-2g5m-vwhr) Remaining: 1 high (braces <=3.0.3 via eslint-config-next -> @next/eslint-plugin-next -> fast-glob -> micromatch, GHSA-vfj7-8cjw-p6xm) has no patched release compatible with micromatch 4's ^3.0.3 range; dev-only lint chain. next 16.4.0 was tried first but the site build fails on it (stack overflow in fumadocs-core's MDX stringifier on content/docs/diagrams.mdx), so this sticks to the minimal patched 16.3.x line. Verified: pnpm build, pnpm lint, pnpm typecheck all pass.
|
Someone is attempting to deploy a commit to the Effective HTML Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm auditonsite/currently reports 16 vulnerabilities (1 critical, 8 high, 6 moderate, 1 low). This PR resolves 15 of them; the last one has no compatible fix.Fixed by
next16.3.5 → 16.3.8 (7 CVEs)next/ogImageResponseuse cachefill leaks Draft Mode contentFixed by in-range transitive refreshes (8 CVEs)
sharp≥ 0.35.5 — librsvg vulnerability (GHSA-wq5f-xc86-pv6w)source-map-js≥ 1.2.2 — event-loop DoS (GHSA-68fv-2mgg-jv7q)brace-expansion— uncontrolled recursion (GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7p) and quadratic-time expansion (GHSA-q2hr-2g5m-vwhr)Remaining: 1 high, no compatible fix
braces≤ 3.0.3 (GHSA-vfj7-8cjw-p6xm) viaeslint-config-next → @next/eslint-plugin-next → fast-glob → micromatch. There is no patched release in the^3.0.3range micromatch 4 requires; chain is dev-only lint tooling.Note on 16.4.0
I first tried
next16.4.0 (current latest), but the site build fails on it with a stack overflow infumadocs-core's MDX stringifier while processingcontent/docs/diagrams.mdx— appears to be a Next 16.4 / fumadocs interaction worth investigating separately. Staying on the minimal patched 16.3.x line avoids it.Verification
pnpm audit: 16 findings → 1 (dev-only, unfixable in range)pnpm build✓pnpm lint✓pnpm typecheck✓