Does pkgm uninstall remove the symlinks as well? #73

Activity

1. sanchitram1 commented on Oct 31, 2025

   

   sanchitram1

   on Oct 31, 2025

   Author

   More actions

   my question is what's happening in the uninstall process? am I missing an additional thing that I gotta remove?
2. jhheider commented on Oct 31, 2025

   

   jhheider

   on Oct 31, 2025

   Contributor

   More actions

   looking at

   pkgm/pkgm.ts

   Lines 540 to 620 in e3934de

   	async function uninstall(arg: string) {
   	let found: { project: string } | undefined =
   	(await hooks.usePantry().find(arg))?.[0];
   	if (!found) {
   	found = await plumbing.which(arg);
   	}
   	if (!found) {
   	console.error(`no such pkg: ${arg}`);
   	return false;
   	}
   	const set = new Set<string>();
   	const files: Path[] = [];
   	let dirs: Path[] = [];
   	const pkg_dirs: Path[] = [];
   	const root = install_prefix();
   	const dir = root.join("pkgs", found.project);
   	if (!dir.isDirectory()) {
   	console.error(`not installed: ${dir}`);
   	if (
   	root.string == "/usr/local" &&
   	Path.home().join(".local/pkgs", found.project).isDirectory()
   	) {
   	console.error(
   	`%c! rerun without \`sudo\` to uninstall ~/.local/pkgs/${found.project}`,
   	"color:yellow",
   	);
   	} else if (new Path("/usr/local/pkgs").join(found.project).isDirectory()) {
   	console.error(
   	`%c! rerun as \`sudo\` to uninstall /usr/local/pkgs/${found.project}`,
   	"color:yellow",
   	);
   	}
   	return false;
   	}
   	console.error("%cuninstalling", "color:red", dir);
   	pkg_dirs.push(dir);
   	for await (const [pkgdir, { isDirectory }] of dir.ls()) {
   	if (!isDirectory) continue;
   	for await (const { path, isDirectory } of walk(pkgdir.string)) {
   	const leaf = new Path(path).relative({ to: pkgdir });
   	const resolved_path = root.join(leaf);
   	if (set.has(resolved_path.string)) continue;
   	if (!resolved_path.exists()) continue;
   	if (isDirectory) {
   	dirs.push(resolved_path);
   	} else {
   	files.push(resolved_path);
   	}
   	}
   	}
   	// we need to delete this in a heirachical fashion or they don’t delete
   	dirs = dirs.sort().reverse();
   	if (files.length == 0) {
   	console.error("unexpectedly not installed");
   	Deno.exit(1);
   	}
   	for (const path of files) {
   	if (!path.isDirectory()) {
   	Deno.removeSync(path.string);
   	}
   	}
   	for (const path of dirs) {
   	if (path.isDirectory()) {
   	try {
   	Deno.removeSync(path.string);
   	} catch {
   	// some dirs will not be removable
   	}
   	}
   	}
   	for (const path of pkg_dirs) {
   	Deno.removeSync(path.string, { recursive: true });
   	}
   	return true;
   	}

   it looks possible the symlinks aren't being cleaned up... maybe? Hence, when it tries to symlink in the new copy, it's erroring. Try this:

   pkgx uninstall libpng.org
   ls -l /Users/sanch/.local/pkgs/libpng.org/v1.6.40/lib/libpng.la
   ls -l /Users/sanch/.local/lib/libpng.la

   we would hope both of those would be gone on uninstall. you mentioned sudo, so it's just possible you've got a root-owned inode that you can't fix as user.
3. sanchitram1 commented on Oct 31, 2025

   

   sanchitram1

   on Oct 31, 2025

   Author

   More actions

   looks like the symlink does exist!

   ~/Library/Mobile Documents/com~apple~CloudDocs/Documents/berkeley/fall 2025 ························· 12:48:01
   ❯ sudo pkgm uninstall libpng.org
   uninstalling /usr/local/pkgs/libpng.org
   
   ~/Library/Mobile Documents/com~apple~CloudDocs/Documents/berkeley/fall 2025 ························· 12:48:05
   ❯ ls -l /Users/sanch/.local/pkgs/libpng.org/v1.6.40/lib/libpng.la
   ls: /Users/sanch/.local/pkgs/libpng.org/v1.6.40/lib/libpng.la: No such file or directory
   
   ~/Library/Mobile Documents/com~apple~CloudDocs/Documents/berkeley/fall 2025 ························· 12:48:16
   ❯ ls -l /Users/sanch/.local/lib/libpng.la                        
   lrwxr-xr-x  1 sanch  staff  57 Oct 31 12:19 /Users/sanch/.local/lib/libpng.la -> /Users/sanch/.local/pkgs/libpng.org/v1.6.40/lib/libpng.la
   
4. jhheider commented on Oct 31, 2025

   

   jhheider

   on Oct 31, 2025

   Contributor

   More actions

   sounds like a pkgm uninstall bug. does removing the symlink get you working?
5. sanchitram1 commented on Oct 31, 2025

   

   sanchitram1

   on Oct 31, 2025

   Author

   More actions

   it's the symlinks – I ran into the next symlink problem:

   error: Uncaught (in promise) AlreadyExists: File exists (os error 17): symlink '/usr/local/pkgs/pip.pypa.io/v23.3.2/bin/pip3' -> '/usr/local/bin/pip3'
     Deno.symlinkSync(src, dst);
          ^
       at Object.symlinkSync (ext:deno_fs/30_fs.js:504:3)
       at symlink_with_overwrite (file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:501:8)
       at processEntry (file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:419:7)
       at eventLoopTick (ext:core/01_core.js:178:7)
       at async processEntry (file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:412:9)
       at async symlink (file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:397:7)
       at async install (file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:159:7)
       at async file:///Users/sanch/.pkgx/pkgx.sh/pkgm/v0.11.1/bin/pkgm:65:20
   

   i'll go ahead and remove all the symlinks and see if it works out
6. sanchitram1 commented on Oct 31, 2025

   

   sanchitram1

   on Oct 31, 2025

   Last edited by sanchitram1

   Author

   More actions

   ~/Library/Mobile Documents/com~apple~CloudDocs/Documents/berkeley/fall 2025 ························· 12:54:05
   ❯ sudo pkgm uninstall pip.pypa.io   
   uninstalling /usr/local/pkgs/pip.pypa.io
   unexpectedly not installed
   

   hmm…? that's a fun turn of phrase . looks like pip is refusing to uninstall for some reason. should I try to manually delete and see what happens then?
7. jhheider commented on Oct 31, 2025

   

   jhheider

   on Oct 31, 2025

   Contributor

   More actions

   yep. sounds like uninstall needs work, and perhaps install needs to give the option to be a bit more aggressive about clobbering things.
8. mxcl commented on Nov 4, 2025

   

   mxcl

   on Nov 4, 2025

   Last edited by mxcl

   Contributor

   More actions

   You need to upgrade pkgx, you probs haven’t done that in a while. I thought we included a version check in pkgm but I guess not.

   -q! is a new(ish) pkgx flag

   👍React with 👍1Reacted by Sanchit Ram Arvind
9. sanchitram1 commented on Nov 4, 2025

   

   sanchitram1

   on Nov 4, 2025

   Author

   More actions

   looks like i've got the latest of all:

   ❯ pkgm --version
   pkgm 0.11.1
   
   ~ ·········································································································· 14:20:43
   ❯ pkgx --version
   pkgx 2.7.0
   
   ~ ·········································································································· 14:21:12
   ❯ dev --version
   dev 1.5.0