This repository was archived by the owner on Oct 22, 2026. It is now read-only.
Repository navigation
Fix ResolveLock not called in Scan API - #2089
Merged
Merged
Conversation
fix resolve lock not called in Scan API Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm
added
needs-cherry-pick-2.3
needs-cherry-pick-release-2.4
Contributor
Author
|
/run-all-tests tidb=v5.0.3 tikv=v5.0.3 pd=v5.0.3 |
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Contributor
Author
|
/run-all-tests tidb=v5.0.3 tikv=v5.0.3 pd=v5.0.3 |
marsishandsome
left a comment
marsishandsome
left a comment
Collaborator
There was a problem hiding this comment.
this PR should port to client-java ?
| while (iterator.hasNext()) { | ||
| Kvrpcpb.KvPair kv = iterator.next(); | ||
| if (kv == null || kv.getKey() == null) { | ||
| if (kv == null || kv.getKey().isEmpty()) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (kv == null || kv.getKey().isEmpty()) { | |
| if (kv == null || kv.getKey() == null || kv.getKey().isEmpty()) { |
Contributor
Author
|
/merge |
Contributor
|
cherry pick to release-2.3 in PR #2090 |
Contributor
|
cherry pick to release-2.4 in PR #2091 |
birdstorm
pushed a commit
that referenced
this pull request
Aug 2, 2021
This was referenced Aug 5, 2021
birdstorm
added a commit
that referenced
this pull request
Sep 6, 2021
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolveLock was not called in Scan API, it would lead to
table or view not found