Skip to content
This repository was archived by the owner on Oct 22, 2026. It is now read-only.

fix bug: write decimal(16, 4) using batch write and read using tiflash - #2054

Merged
marsishandsome merged 1 commit into
pingcap:release-2.3from
marsishandsome:feature/fix-batchwrite-decimal-tiflash
Apr 29, 2021
Merged

fix bug: write decimal(16, 4) using batch write and read using tiflash#2054
marsishandsome merged 1 commit into
pingcap:release-2.3from
marsishandsome:feature/fix-batchwrite-decimal-tiflash

Conversation

@marsishandsome

@marsishandsome marsishandsome commented Apr 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

close #2053

What is changed and how it works?

use the precision and frac from column instead of real data when encoding Decimal Type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@marsishandsome marsishandsome added needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 labels Apr 28, 2021
@marsishandsome
marsishandsome force-pushed the feature/fix-batchwrite-decimal-tiflash branch from 5a91366 to edacdc5 Compare April 28, 2021 06:32
@marsishandsome

marsishandsome commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

birdstorm
birdstorm previously approved these changes Apr 28, 2021
View reviewed changes

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marsishandsome
marsishandsome force-pushed the feature/fix-batchwrite-decimal-tiflash branch from edacdc5 to e605e48 Compare April 28, 2021 09:02
@marsishandsome

marsishandsome commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator Author

/run-all-tests

@marsishandsome
marsishandsome merged commit 98b12ab into pingcap:release-2.3 Apr 29, 2021
@ti-srebot ti-srebot mentioned this pull request Apr 29, 2021
Merged
@ti-srebot

ti-srebot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

cherry pick to release-2.4 in PR #2055

@ti-srebot ti-srebot mentioned this pull request Apr 29, 2021
Merged
@ti-srebot

ti-srebot commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

cherry pick to master in PR #2056

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@birdstorm birdstorm birdstorm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-master PR which needs to be cherry-picked to master needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsishandsome @ti-srebot @birdstorm