Skip to content
This repository was archived by the owner on Oct 22, 2026. It is now read-only.

fix Residual Filter containing wrong info - #1308

Merged
zhexuany merged 6 commits into
pingcap:masterfrom
zhexuany:fix_explain
Dec 12, 2019
Merged

zhexuany merged 6 commits into
pingcap:masterfrom
zhexuany:fix_explain

Conversation

@zhexuany

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

This PR fixes explain info having wrong information.

@zhexuany

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@marsishandsome

Copy link
Copy Markdown
Collaborator

need cherry-pick ?

@birdstorm

Copy link
Copy Markdown
Contributor

add some tests?

@marsishandsome

Copy link
Copy Markdown
Collaborator

two fix on title ?

@birdstorm

Copy link
Copy Markdown
Contributor

consider move the test into PlanTestSuite?

@zhexuany zhexuany changed the title fix fix Residual Filter containing wrong info fix Residual Filter containing wrong info Dec 12, 2019
@zhexuany

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@birdstorm birdstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@marsishandsome marsishandsome left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@zhexuany
zhexuany merged commit 897acea into pingcap:master Dec 12, 2019
@zhexuany
zhexuany deleted the fix_explain branch December 12, 2019 09:55
@sre-bot

sre-bot commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

cherry pick to release-2.1 failed

@sre-bot

sre-bot commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

cherry pick to release-2.2 failed

wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants