Conversation
getBarcode("08123172389739") succeeded. EAN-13 is 13 digits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeEanUpcBasepads a short code up to the data length, then checks the digit at that position. A longer code is not rejected.getBarcode("08123172389739")succeeded because digit 13 is the real EAN-13 check digit and the extra9was kept.A code longer than the symbology now throws
InvalidLengthException.081231723897still becomes0812317238973. The same cap applies to EAN-8 and UPC-A.Test plan
testEan13RejectsAnExtraDigitfails because no exception is thrownvendor/bin/phpunitpassesMade with Cursor