Simplify adding annotations to the manifest

Per #201 annotations have been added to the manifest/index file. The way this is done is rather cumbersome at the moment. When docker/build-push-action#958 is solved by means of docker/build-push-action#992, together with docker/metadata-action#351, we can simplify this:

amp-devcontainer/.github/workflows/build-push.yml

Lines 58 to 70 in 1afec52

    
           - uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0 
        
             id: build-and-push 
        
             with: 
        
               file: .devcontainer/Dockerfile 
        
               platforms: linux/amd64,linux/arm64 
        
               push: ${{ github.event_name != 'merge_group' }} 
        
               tags: ${{ steps.meta.outputs.tags }} 
        
               labels: ${{ steps.meta.outputs.labels }} 
        
               outputs: type=image,${{ steps.annotations.outputs.annotations }} 
        
               sbom: true 
        
               provenance: true 
        
               cache-from: type=gha 
        
               cache-to: type=gha,mode=max

to:

- uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0
  id: build-and-push
  with:
    file: .devcontainer/Dockerfile
    platforms: linux/amd64,linux/arm64
    push: ${{ github.event_name != 'merge_group' }}
    tags: ${{ steps.meta.outputs.tags }}
    labels: ${{ steps.meta.outputs.labels }}
    annotations: ${{ steps.meta.outputs.labels }}
    sbom: true
    provenance: true
    cache-from: type=gha
    cache-to: type=gha,mode=max

And remove this:

amp-devcontainer/.github/workflows/build-push.yml

Lines 45 to 49 in 1afec52

    
                 - run: | 
        
                     set -Eeuo pipefail 
        
                     ANNOTATIONS=$(echo '${{ steps.meta.outputs.labels }}' | sed 's/org.opencontainers.image./annotation-index.org.opencontainers.image./' | tr '\n' ',') 
        
                     echo "annotations=${ANNOTATIONS::-1}" >> "$GITHUB_OUTPUT" 
        
                   id: annotations

Thank you for adding your first issue. We will be looking into it as soon as possible.

Closed by #225

Navigation Menu

Repository navigation

Simplify adding annotations to the manifest #202

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	- uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0
	id: build-and-push
	with:
	file: .devcontainer/Dockerfile
	platforms: linux/amd64,linux/arm64
	push: ${{ github.event_name != 'merge_group' }}
	tags: ${{ steps.meta.outputs.tags }}
	labels: ${{ steps.meta.outputs.labels }}
	outputs: type=image,${{ steps.annotations.outputs.annotations }}
	sbom: true
	provenance: true
	cache-from: type=gha
	cache-to: type=gha,mode=max

	- run: \|
	set -Eeuo pipefail
	ANNOTATIONS=$(echo '${{ steps.meta.outputs.labels }}' \| sed 's/org.opencontainers.image./annotation-index.org.opencontainers.image./' \| tr '\n' ',')
	echo "annotations=${ANNOTATIONS::-1}" >> "$GITHUB_OUTPUT"
	id: annotations

Simplify adding annotations to the manifest #202

Description

Activity

github-actions commented on Nov 10, 2023

rjaegers commented on Dec 2, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions