Skip to content

add font awesome - #188

Merged
illepic merged 4 commits into
epic/v10from
font-awesome
Dec 18, 2017
Merged

illepic merged 4 commits into
epic/v10from
font-awesome

Conversation

@tjheffner

Copy link
Copy Markdown
Contributor

this PR:

  • adds font-awesome as an npm dependency
  • includes local font files in source/
  • demonstrates how to import an npm module's sass and overwrite variables for that sass locally
  • updates icons demo to show font-awesome implementation also

@tjheffner
tjheffner requested a review from illepic December 11, 2017 23:16

@illepic illepic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjheffner : Can we get an example in scss of using a few of the FontAwesome mixins provided?

Not a biggie, but would be rad to maybe even get it included in with our regular icons mixin too?


@import 'icon-mixins';
@import '~font-awesome/scss/mixins';
@import '~font-awesome/scss/variables';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noting these files don't have printing output, totally fine to include here.

@illepic
illepic merged commit 8ad1707 into epic/v10 Dec 18, 2017
@illepic
illepic deleted the font-awesome branch December 18, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants