Fix typeddict issue with generics - #120
Merged
Merged
Conversation
semohr
force-pushed
the
fix_typeddict
branch
2 times, most recently
from
May 9, 2026 14:02
fd3b664 to
f19022a
Compare
Contributor
Author
|
Am not really too sure where the mypy issue comes from, but it seems to be raised on the main branch too. |
Contributor
Author
|
@pgjones Hope it’s okay to ping you. Anything I can do to help push this along? |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pgjones,
I had some time to fix the issue #119 this afternoon.
This PR extends the model_class conversion guard to less strict version, which supports generic
TypedDicttypes.Further I refactored the test around conversion slightly to add tests for the
TypedDict[Generic]edge case.Best, S