bug(ClipboardCopy): change children type to string - #9743
Merged
tlabaj merged 5 commits intoNov 15, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9711
the type of ReactNode isn't truly supported as anything passed in will be converted to a string. this caused confusion for at least one product.
none of the examples were attempting to use anything other than a string, and i don't imagine a use case for doing so. I feel like the "text to copy" should actually have been placed in a different prop (
text,textToCopy, ?) instead of usingchildren, but this would be a breaking change.the product that came across this was attempting to create a "header/title/summary" of the text to be copied, this will be possible via #9713