This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Frame remove_all with size limit. - #9106
Merged
5 commits merged intoJun 15, 2021
Merged
5 commits merged into
5 commits merged into
Conversation
cheme
added
A0-please_review
Member
The solution is simply to add |
Contributor
Author
Yes, updating is very straight forward. Seems better to me than having two function for the same thing. |
athei
reviewed
Jun 15, 2021
athei
left a comment
athei
left a comment
Member
There was a problem hiding this comment.
API changes look good to me. But we need to remove some duplication.
athei
approved these changes
Jun 15, 2021
shawntabrizi
approved these changes
Jun 15, 2021
Member
|
bot merge |
|
Trying merge. |
Contributor
|
maybe it worth documenting that the function remove_all, and warn that it removes all overlay, and up to limit in the backend, people shouldn't rely on the fact that it removes exactly up to the limit. |
rphmeier
pushed a commit
that referenced
this pull request
Jun 18, 2021
* remove prefixed content with limit. * test match * factor comment and factor ext limit removal. * fix benchmark Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
5 of 7 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9002.
Note that it breaks existing frame api (could have define new function with the limit but it does not seem good).
Affected APIs:
remove_prefixclear_prefixkill_prefixremove_allTo fix these APIs to act the same as before, simply add an additional input parameter of
None.Also rename:
KillChildStorageResult->KillStorageResultpolkadot companion: paritytech/polkadot#3257