This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Repository navigation
Rename ModuleToIndex to PalletRuntimeSetup - #7148
Merged
5 commits merged intoSep 22, 2020
Merged
5 commits merged into
5 commits merged into
Conversation
Besides the renaming it also adds support getting the name of a pallet as configured in the runtime.
bkchr
added
A0-please_review
bkchr
requested review from
andresilva,
kianenigma,
mxinden,
pepyakin and
sorpaas
as code owners
September 18, 2020 17:21
Member
Author
|
I hate my naming. @shawntabrizi or anyone else has a better idea, please say it |
Member
|
I would call this "PalletInfo"? Or "PalletIdentity"/"PalletId" |
gui1117
approved these changes
Sep 21, 2020
gui1117
left a comment
gui1117
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me,
I like the name PalletRuntimeSetup as it contains the information given by the setup of the runtime. But I'm ok with PalletInfo. Maybe PalletSetup is better ?
I feel "PalletIdentity"/"PalletId" is too vague somehow :-) but anyway fine.
Contributor
|
➕ |
Member
Author
|
Renamed it to |
Member
Author
|
@kianenigma and @shawntabrizi please review :D |
shawntabrizi
approved these changes
Sep 22, 2020
Contributor
|
bot merge |
|
Trying merge. |
sorpaas
pushed a commit
that referenced
this pull request
Nov 20, 2020
* Rename `ModuleToIndex` to `PalletRuntimeSetup` Besides the renaming it also adds support getting the name of a pallet as configured in the runtime. * Rename it to `PalletInfo` * Remove accidentally added files
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the renaming it also adds support getting the name of a pallet
as configured in the runtime.
Migrating changes
For anyone coming here to migrate its old to the new code:
ModuleToIndextoPalletRuntimeSetup.module_to_indexwithindex.polkadot companion: paritytech/polkadot#1743