Skip to content

fix(sdk-core): honor xcmFormatCheck option in BatchTransactionManager.buildBatch (#2501) - #2542

Closed
KrazyArcher wants to merge 1 commit into
paraspell:mainfrom
KrazyArcher:fix/batch-xcm-format-check-2501
Closed

KrazyArcher wants to merge 1 commit into
paraspell:mainfrom
KrazyArcher:fix/batch-xcm-format-check-2501

Conversation

@KrazyArcher

Copy link
Copy Markdown

Fixes #2501

Summary

Previously, xcmFormatCheck: true was only evaluated inside GeneralBuilder.buildCommon() during single-transfer builds. When constructing batched transfers via Builder.buildBatch() (or POST /x-transfer-batch in the XCM API), BatchTransactionManager.buildBatch() created each transfer/swap extrinsic and invoked api.callBatchMethod(txs, mode) without invoking maybePerformXcmFormatCheck(...).

Changes

  • Exposed maybePerformXcmFormatCheck on GeneralBuilder (packages/sdk-core/src/builder/Builder.ts).
  • Updated BatchTransactionManager.buildBatch (packages/sdk-core/src/builder/BatchTransactionManager.ts) to invoke await builder.maybePerformXcmFormatCheck(tx, substrateOptions, false) for each normalized transaction in the batch before calling api.callBatchMethod(txs, mode).
  • Added unit and regression tests in BatchTransactionManager.test.ts and Builder.test.ts verifying that xcmFormatCheck runs dry-run validation for every batched transaction and propagates DryRunFailedError before batch creation if any check fails.

Verification

  • pnpm --filter @paraspell/sdk-core test src/builder/BatchTransactionManager.test.ts src/builder/Builder.test.ts — 78/78 tests passing.
  • pnpm --filter @paraspell/sdk-core exec tsc --noEmit — 0 errors.

@KrazyArcher
KrazyArcher force-pushed the fix/batch-xcm-format-check-2501 branch from 79e3d98 to 4c532b3 Compare November 16, 2026 06:33
…ldBatch (paraspell#2501)

Signed-off-by: KrazyArcher <199054583+KrazyArcher@users.noreply.github.com>
AI-Assisted-By: Gemini 4 Argon & Carbon
@KrazyArcher
KrazyArcher force-pushed the fix/batch-xcm-format-check-2501 branch from 4c532b3 to ad76e06 Compare November 16, 2026 06:45
@dudo50

dudo50 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Dear @KrazyArcher
Thanks for interest in contributing to ParaSpell tool stack.

Unfortunately in order to contribute you need to have issue reserved for you. The original reporter needs to say they do not want to carry out the FIX. You also did not adhere to bug bounty PR format.

More information on program: https://paraspell.github.io/docs/contribution-guidelines.html

Closing.

With kind regards,
Team ParaSpell✨

@dudo50 dudo50 closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug bounty] xcmFormatCheck option is ignored for batch transfers (buildBatch / x-transfer-batch)

2 participants