Repository navigation
fix(sdk-core): honor xcmFormatCheck option in BatchTransactionManager.buildBatch (#2501) - #2542
Closed
KrazyArcher wants to merge 1 commit into
Closed
KrazyArcher wants to merge 1 commit into
KrazyArcher wants to merge 1 commit into
Conversation
KrazyArcher
force-pushed
the
fix/batch-xcm-format-check-2501
branch
from
November 16, 2026 06:33
79e3d98 to
4c532b3
Compare
…ldBatch (paraspell#2501) Signed-off-by: KrazyArcher <199054583+KrazyArcher@users.noreply.github.com> AI-Assisted-By: Gemini 4 Argon & Carbon
KrazyArcher
force-pushed
the
fix/batch-xcm-format-check-2501
branch
from
November 16, 2026 06:45
4c532b3 to
ad76e06
Compare
Contributor
|
Dear @KrazyArcher Unfortunately in order to contribute you need to have issue reserved for you. The original reporter needs to say they do not want to carry out the FIX. You also did not adhere to bug bounty PR format. More information on program: https://paraspell.github.io/docs/contribution-guidelines.html Closing. With kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2501
Summary
Previously,
xcmFormatCheck: truewas only evaluated insideGeneralBuilder.buildCommon()during single-transfer builds. When constructing batched transfers viaBuilder.buildBatch()(orPOST /x-transfer-batchin the XCM API),BatchTransactionManager.buildBatch()created each transfer/swap extrinsic and invokedapi.callBatchMethod(txs, mode)without invokingmaybePerformXcmFormatCheck(...).Changes
maybePerformXcmFormatCheckonGeneralBuilder(packages/sdk-core/src/builder/Builder.ts).BatchTransactionManager.buildBatch(packages/sdk-core/src/builder/BatchTransactionManager.ts) to invokeawait builder.maybePerformXcmFormatCheck(tx, substrateOptions, false)for each normalized transaction in the batch before callingapi.callBatchMethod(txs, mode).BatchTransactionManager.test.tsandBuilder.test.tsverifying thatxcmFormatCheckruns dry-run validation for every batched transaction and propagatesDryRunFailedErrorbefore batch creation if any check fails.Verification
pnpm --filter @paraspell/sdk-core test src/builder/BatchTransactionManager.test.ts src/builder/Builder.test.ts— 78/78 tests passing.pnpm --filter @paraspell/sdk-core exec tsc --noEmit— 0 errors.