Apply an excessively permissive large string length limit by default - #2601
Merged
Merged
Conversation
This allows us to bridge the difference between jackson 2.14 and 2.15 such that we are able to safely upgrade, even if the upgrade occurs before CJR is prepared to take the upgrade itself. We will ratchet down the default over time.
Generate changelog in
|
Collaborator
|
Released 7.52.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to bridge the difference between jackson 2.14 and 2.15 such that we are able to safely upgrade, even if the upgrade occurs before CJR is prepared to take the upgrade itself.
We will ratchet down the default over time.
==COMMIT_MSG==
Apply a large StreamReadConstraints maxStringLength to reduce friction in preparation for jackson 2.15 adoption
==COMMIT_MSG==
Possible downsides?
This is a very large value, nearly equivalent to no limit. However, we limit the total request size for structured data already.
Testing: It's difficult to test this change because we do not want to add a dependency on 2.15.0-rc3+, however I have verified that the new test fails without this patch, and passes once the patch has been applied.