Repository navigation
Conversation
Per the reference manuals (RM0316, RM0433), the baud rate register may only be written while the USART is disabled (UE=0). Move the UE enable after the BRR write in both the stm32fx and stm32h7 USART drivers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2707.
RM0433 and RM0316 require that the baud-rate register
BRRonly be written while the USART is disabled (UE=0), but both the stm32h7 and stm32fx USART drivers setUE=1before writingBRR. This reorders the init sequence in both drivers soBRRis programmed first and the USART is enabled afterwards. No functional change otherwise.