Repository navigation
Make tlvc a gitdep - #2732
Open
labbott wants to merge 1 commit into
Open
Make tlvc a gitdep#2732labbott wants to merge 1 commit into
tlvc a gitdep#2732labbott wants to merge 1 commit into
Conversation
There's been an effort to switch over to git revisions instead of version due to conflicts (see hubtools#67). Match this and switch over to a gitrev (while also doing a bump to fix an issue with `no_std`).
jamesmunns
reviewed
Oct 9, 2026
| spd = { git = "https://github.com/oxidecomputer/spd", default-features = false } | ||
| tlvc = { git = "https://github.com/oxidecomputer/tlvc", default-features = false, version = "0.4.0" } | ||
| tlvc-text = { git = "https://github.com/oxidecomputer/tlvc", default-features = false, version = "0.4.0" } | ||
| tlvc = { git = "https://github.com/oxidecomputer/tlvc", default-features = false, rev = "12f6bf8cd5b04715a9e0efefeb4c9bb4a2c0e4ca" } |
Contributor
There was a problem hiding this comment.
Do we want to pin a specific version using rev, vs just keeping the rev as part of the Cargo.lock? Right now it looks like most of the surrounding git deps are more loosely specified.
I don't have any strong feelings either way, but it does seem somewhat inconsistent (though dice-util, for example, also sets a specific rev).
Collaborator
Author
There was a problem hiding this comment.
See what I mentioned in the commit message oxidecomputer/hubtools#67
Collaborator
Author
There was a problem hiding this comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's been an effort to switch over to git revisions instead of version due to conflicts (see hubtools#67). Match this and switch over to a gitrev (while also doing a bump to fix an issue with
no_std).