Skip to content

refactor(clippy): apply clippy's lint - #1631

Merged
orhun merged 7 commits into
orhun:mainfrom
ognis1205:fix/cargo-clippy
Sep 6, 2026
Merged

refactor(clippy): apply clippy's lint#1631
orhun merged 7 commits into
orhun:mainfrom
ognis1205:fix/cargo-clippy

Conversation

@ognis1205

Copy link
Copy Markdown
Contributor

Description

Fixes Clippy lint warnings that caused the CI lint job to fail.

Motivation and Context

The CI lint job was failing on the Lints step.

This change resolves those errors so that the continuous integration pipeline passes successfully and future warnings are caught early.

How Has This Been Tested?

  • Ran cargo clippy --tests --verbose -- -D warnings locally and confirmed it exits cleanly with no errors or warnings.
  • Ran cargo +nightly fmt --all to ensure formatting is consistent.
  • Ran cargo test to verify that all existing tests still pass after the lint fixes.

Screenshots / Logs (if applicable)

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (if applicable).
  • I have formatted the code with rustfmt.
    • cargo +nightly fmt --all
  • I checked the lints with clippy.
    • cargo clippy --tests --verbose -- -D warnings
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    • cargo test

@ognis1205
ognis1205 requested a review from orhun as a code owner September 6, 2026 20:32
@codecov-commenter

codecov-commenter commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.85567% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.34%. Comparing base (8fc0aef) to head (19913b5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 29 Missing ⚠️
git-cliff-core/src/config.rs 16.67% 5 Missing ⚠️
git-cliff-core/src/changelog.rs 90.91% 2 Missing ⚠️
git-cliff-core/src/commit.rs 96.78% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
+ Coverage   53.27%   53.34%   +0.08%     
==========================================
  Files          28       28              
  Lines        2621     2625       +4     
==========================================
+ Hits         1396     1400       +4     
  Misses       1225     1225              
Flag Coverage Δ
unit-tests 53.34% <61.86%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun
orhun merged commit 4533ff7 into orhun:main Sep 6, 2026
113 of 115 checks passed
@ognis1205
ognis1205 deleted the fix/cargo-clippy branch September 6, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants