Repository navigation
dns/ddclient: add porkbun support to native backend - #5599
Merged
Merged
Conversation
|
Ah finally big fan of this! |
|
Hi @5t0n3, @AdSchellevis, and others. I have been running a modified version of this PR in my router for the last month or so, and it has been successfully updating both my IPv4 and IPv6 addresses for my Porkbun domain. This is something I couldn't make work with the legacy ddclient. I tried to handle all the edge cases. The script first tries updating records, which works if they exist. If they don't, it tries to create them. I would love to get these changes integrated to mainline. My current PR is targeting your fork, @5t0n3. I didn't want to open a duplicate PR to the main plugins project, but I can if this would be better. My current PR is the one above, 5t0n3#1. |
Member
|
merged, thanks! |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
Describe the problem
The existing ddclient-based Porkbun dynamic DNS backend only supports setting subdomain records (e.g.,
subdomain.example.combut notexample.com) due to theon-root-domainoption not being exposed in the OPNSense UI. It sounds likeddclientmay be removed from OPNsense soon as well (see e.g. opnsense/ports#223 (comment)), at which point OPNsense would not support Porkbun DNS at all.Describe the proposed solution
This PR adds a Python implementation to the native dynamic dns backend to support Porkbun's API. I modeled it after the Cloudflare backend script with changes to suit the different API structure.
Related issue
#4761 (mentions non-root-domain breakage)