Skip to content

menu: close the mobile menu when a menu entry opens another tab of th… - #10942

Open
Greelan wants to merge 1 commit into
opnsense:masterfrom
Greelan:menu-same-page-close
Open

Greelan wants to merge 1 commit into
opnsense:masterfrom
Greelan:menu-same-page-close

Conversation

@Greelan

@Greelan Greelan commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

…e current page

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

If AI was used, please disclose:

  • Model used:
  • Extent of AI involvement:

Describe the problem

On mobile, choosing a menu entry that points to another tab of the page already open (like VPN: WireGuard: Peers while on Instances) leaves the menu open over the page. Only the URL fragment changes, so no page load closes it; the page's own hashchange handler switches the tab underneath.


Describe the proposed solution

This PR closes #navigation in that case, using the same check the Favorites code uses, for both MVC and legacy.


Related issue

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants