Skip to content

uber-trace-id from incoming request overwrites client span in spring cloud gateway tracing #340

New issue
New issue
Open
#341
Open
uber-trace-id from incoming request overwrites client span in spring cloud gateway tracing#340
#341

Description

@rafis
rafis
opened on Jan 23, 2023

Client span is generated here:

java-spring-cloud/instrument-starters/opentracing-spring-cloud-gateway-starter/src/main/java/io/opentracing/contrib/spring/cloud/gateway/TraceRequestHttpHeadersFilter.java

Lines 55 to 60 in 8a865d5

Span span = this.tracer.buildSpan(path(builder))
.asChildOf(tracer.activeSpan())
.withTag(Tags.COMPONENT.getKey(), COMPONENT)
.withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT)
.withTag(ROUTE_ID, getRouteId(exchange))
.start();

Next we try to inject this span into Http Headers of inner request:

java-spring-cloud/instrument-starters/opentracing-spring-cloud-gateway-starter/src/main/java/io/opentracing/contrib/spring/cloud/gateway/TraceRequestHttpHeadersFilter.java

Lines 65 to 70 in 8a865d5

this.tracer.inject(span.context(), Format.Builtin.HTTP_HEADERS, new HttpHeadersCarrier(headersWithInput));
} catch (Exception ignore) {
log.error("TraceRequestHttpHeadersFilter error", ignore);
}
headersWithInput.addAll(input);
addHeadersWithInput(builder, headersWithInput);

But if the incoming request to Spring Cloud Gateway had it own uber-trace-id header this will overwrite what we just tried to do. Is it a bug?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions