Skip to content

CORENET-7353: OTE: register egress-router-cni test extension binary#31381

Open
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:ote-egressrouter-registration
Open

CORENET-7353: OTE: register egress-router-cni test extension binary#31381
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:ote-egressrouter-registration

Conversation

@anuragthehatter

@anuragthehatter anuragthehatter commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verify CI builds successfully
  • Use /testwith openshift/egress-router-cni#105 to validate end-to-end

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Added support for discovering, extracting, and running the egress-router-cni test extension binary.

Companion to openshift/egress-router-cni#105

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Walkthrough

The extension binary registry now maps the egress-router-cni image tag to /usr/bin/egress-router-cni-tests-ext.gz for discovery and extraction.

Changes

Egress Router CNI Binary

Layer / File(s) Summary
Register egress-router-cni test binary
pkg/test/extensions/binary.go
Adds the egress-router-cni image tag and its external test binary path to the registry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only an extension-binary registry entry changed; no Ginkgo titles or test definitions were added or modified.
Test Structure And Quality ✅ Passed PR only adds an extension binary registry entry in binary.go; no Ginkgo test code or test structure changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only adds an extension-binary registry entry; no new Ginkgo tests or MicroShift-sensitive APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds a payload binary registry entry in pkg/test/extensions/binary.go; no new Ginkgo tests or SNO-sensitive logic were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only a test-binary registry entry was added in pkg/test/extensions/binary.go; no manifests, controllers, replicas, affinity, or node selectors changed.
Ote Binary Stdout Contract ✅ Passed PR only adds a registry entry for egress-router-cni; no process-level stdout writes were introduced or modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds an extension binary registry entry in pkg/test/extensions/binary.go; no new Ginkgo tests or network assumptions were introduced.
No-Weak-Crypto ✅ Passed Change only adds an egress-router-cni binary registry entry; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code found.
Container-Privileges ✅ Passed The PR only adds an egress-router-cni registry entry in pkg/test/extensions/binary.go; no K8s/container privilege fields were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a registry mapping for egress-router-cni; no new logging statements or sensitive-data handling were introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: registering the egress-router-cni test extension binary.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from p0lyn0mial and sjenning July 10, 2026 18:52
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 10, 2026
@anuragthehatter anuragthehatter changed the title OTE: register egress-router-cni test extension binary CORENET-7353: OTE: register egress-router-cni test extension binary Jul 10, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown

@anuragthehatter: This pull request references CORENET-7353 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Test plan

  • Verify CI builds successfully
  • Use /testwith openshift/egress-router-cni#105 to validate end-to-end

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
  • Added support for discovering, extracting, and running the egress-router-cni test extension binary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi 4183260 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-csi 4183260 link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn-upgrade 4183260 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn 4183260 link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-microshift-serial 4183260 link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-microshift 4183260 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-metal-ipi-ovn-ipv6 4183260 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn 4183260 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial-2of2 4183260 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-csi 4183260 link true /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-serial-1of2 4183260 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-fips 4183260 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants