TRT-2689: Add verify-apm to the verify target

[smg247]

Ensures that apm generation stays up-to-date

Summary by CodeRabbit

• Chores
  • The standard verification command now also checks that generated APM documentation files are up to date.
  • The verification command will report failures when APM documentation needs regeneration.
• Chores
  • APM-related tooling now runs with CI-appropriate caching behavior to improve reliability during automated runs.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@smg247: This pull request references TRT-2689 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Ensures that apm generation stays up-to-date

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9d829a06-5529-4dca-88b1-74adfec45180

📥 Commits

Reviewing files that changed from the base of the PR and between 4f596d1 and d241cca.

📒 Files selected for processing (1)

• Makefile

---

Walkthrough

make verify now runs origin and APM checks. The APM target conditionally passes --no-cache to uvx in CI for both installation and compilation.

Changes

Makefile verification and APM commands

Layer / File(s)	Summary
Extend verify target Makefile	The verify target now depends on verify-origin and verify-apm, and is declared phony.
Add CI-specific uvx flags Makefile	The APM target passes conditional uvx flags to its install and compile commands, using --no-cache when CI is true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: adding verify-apm to the verify target.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only Makefile targets changed; no Ginkgo test names were added or modified.
Test Structure And Quality	✅ Passed	PR changes only Makefile; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only Makefile changed; no new or modified Ginkgo e2e tests were added, so MicroShift compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only Makefile changed; no new Ginkgo/e2e tests were added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only Makefile verification targets changed; no manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	Only Makefile recipes changed; no process-level binary code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only Makefile targets changed; no Ginkgo e2e tests or network-sensitive test code was added or modified.
No-Weak-Crypto	✅ Passed	The diff only updates Makefile targets and uvx flags; no crypto code or weak-crypto patterns appear in the change.
Container-Privileges	✅ Passed	PR changes only Makefile; no container/K8s manifests or privilege-related fields were added or modified.
No-Sensitive-Data-In-Logs	✅ Passed	Only Makefile changes were made, and the added logging is a generic error/status check with no secrets, PII, tokens, or hostnames exposed.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Makefile`:
- Line 53: Declare the verify target as phony by adding verify to the existing
.PHONY declaration in the Makefile, ensuring verify-origin and verify-apm always
run.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 128ff368-08f7-4a08-8221-137b3ff577d3

📥 Commits

Reviewing files that changed from the base of the PR and between 0f64c49 and b1b0e9d.

📒 Files selected for processing (1)

• Makefile

[openshift-ci]

@smg247: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	2f7990e	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.