Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wf9a5m75
added a commit
to MapConductor/ios-for-openmobilemaps
that referenced
this pull request
Oct 24, 2026
scripts/api-surface.sh now covers OpenMobileMaps. Building maps-core with library evolution needs openmobilemaps/maps-core#931 (import Combine in two layer files).
wf9a5m75
added a commit
to MapConductor/ios-for-openmobilemaps
that referenced
this pull request
Oct 24, 2026
* Add OpenMobileMapsDesign.none: no tile layer at all An empty template means no design layer is set, so only what the app adds is drawn. * feat: integrate vector style support and pending map fixes * remove unnecessary file * Record the public API baseline scripts/api-surface.sh now covers OpenMobileMaps. Building maps-core with library evolution needs openmobilemaps/maps-core#931 (import Combine in two layer files).
Author
|
Please review this PR. Thank you. |
Collaborator
|
Thanks for the PR! This is already fixed in our internal repository, and the fix will be included in the upcoming release. |
wf9a5m75
added a commit
to MapConductor/ios-sdk
that referenced
this pull request
Nov 5, 2026
api-surface.sh now dumps and checks ios-for-openmobilemaps. maps-core 4.0.0 does not build with library evolution until openmobilemaps/maps-core#931 lands, so the check needs the local maps-core with that change. ios-vectorstyle and ios-vectortile require the published core from 1.3.2, like the other modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #930
RasterLayer.swiftandVectorLayer.swiftconformpublic/openclasses toObservableObjectwithout importingCombine. With library evolution enabled (BUILD_LIBRARY_FOR_DISTRIBUTION=YES) this is an error:This adds
import Combineto both files. No behaviour change.Tested with Xcode 27.1 (Swift 6.4): building a package that depends on maps-core with
BUILD_LIBRARY_FOR_DISTRIBUTION=YESforgeneric/platform=iOS Simulatorfails without this change and succeeds with it.