Skip to content

refactor: Separate course outline data and sidebar context logic - #2143

Open
xitij2000 wants to merge 1 commit into
openedx:masterfrom
open-craft:kshitij/course-outline-split
Open

xitij2000 wants to merge 1 commit into
openedx:masterfrom
open-craft:kshitij/course-outline-split

Conversation

@xitij2000

@xitij2000 xitij2000 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Splits useCourseOutlineSidebar into useCourseOutlineData and useCourseOutlineSidebar for improved separation of responsibilities. Updates components to reflect this change.

This allows the course outline to be used outside of a sidebar context.

This is a rebase of #1920

private-ref: https://tasks.opencraft.com/browse/BB-10736

Splits useCourseOutlineSidebar into useCourseOutlineData and
useCourseOutlineSidebar for improved separation of responsibilities.
Updates components to reflect this change.

This allows the course outline to be used outside of a sidebar context.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 30, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (76fa1f0) to head (d99b69d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2143   +/-   ##
=======================================
  Coverage   95.05%   95.06%           
=======================================
  Files         372      372           
  Lines        6051     6055    +4     
  Branches     1486     1439   -47     
=======================================
+ Hits         5752     5756    +4     
  Misses        287      287           
  Partials       12       12           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd

itsjeyd commented Oct 6, 2026

Copy link
Copy Markdown

@xitij2000 Will this go through OpenCraft internal review or did you want to hand it over to Brian right away?

@xitij2000

Copy link
Copy Markdown
Contributor Author

@itsjeyd This is just a rebase of #1920. I just did it in a new branch because there were too many conflicts to copying changes over was easier.

@itsjeyd

itsjeyd commented Oct 13, 2026

Copy link
Copy Markdown

@xitij2000 So no internal review then, I take it.

Since Brian reviewed #1920, please ping him here when you're ready for him to have a look at the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants