Repository navigation
Conversation
Splits useCourseOutlineSidebar into useCourseOutlineData and useCourseOutlineSidebar for improved separation of responsibilities. Updates components to reflect this change. This allows the course outline to be used outside of a sidebar context.
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
=======================================
Coverage 95.05% 95.06%
=======================================
Files 372 372
Lines 6051 6055 +4
Branches 1486 1439 -47
=======================================
+ Hits 5752 5756 +4
Misses 287 287
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@xitij2000 Will this go through OpenCraft internal review or did you want to hand it over to Brian right away? |
|
@xitij2000 So no internal review then, I take it. Since Brian reviewed #1920, please ping him here when you're ready for him to have a look at the changes. |
Splits useCourseOutlineSidebar into useCourseOutlineData and useCourseOutlineSidebar for improved separation of responsibilities. Updates components to reflect this change.
This allows the course outline to be used outside of a sidebar context.
This is a rebase of #1920
private-ref: https://tasks.opencraft.com/browse/BB-10736