Skip to content

Take core 7.1.0, and put the editing tools under the bar - #195

Open
andiwand wants to merge 5 commits into
mainfrom
core-7-editing
Open

andiwand wants to merge 5 commits into
mainfrom
core-7-editing

Conversation

@andiwand

@andiwand andiwand commented Sep 18, 2026

Copy link
Copy Markdown
Member

What changes

  • odrcore 7.1.0, up from 6.13.0. Documents, text files and PDFs save through the core's own calls.
  • Every document renders with its editor, so the pencil only turns editing on and the page stays where it is.
  • A row of tools under the bar: formatting, undo and redo for a text document; undo and redo for a sheet or a text file; five markers for a PDF, each with its own colour.
  • A save button beside the pencil. A save stays in the edit, as on the website.
  • Leaving an edit asks about saving only if the page has a change.
  • The page reports to the app through one script message handler: undo and redo state, unsaved changes, the style under the caret, stale formula cells, refusals and the PDF mark count.

Pro and Lite

Features.advancedEditing comes from ADVANCED_EDITING: false in Lite, true in Pro.

Lite Pro
text inside one paragraph yes yes
sheet cells, plain text yes yes
formatting, split or merge a paragraph offers Pro, once per edit yes
mark up a PDF offers Pro yes

Lite renders with the paragraph scope, so the core refuses edits past one paragraph. This is the same line as OpenDocument.droid #662. The UI matches #662 and the website. The one difference: iOS also offers "Other color…" from the system picker.

odrcore 7.1.0 also fixes undo of multi-step edits (opendocument-app/OpenDocument.core#904) and composed input such as CJK keyboards and dictation (opendocument-app/OpenDocument.core#905).

Not in here

  • Separate screenshots for Pro and Lite. That is the next step.
  • Store listing and house ad text about Pro editing.

Tests

  • EditWorkflowTests: the pencil and the save button, the tool rows for a text document, a sheet and a PDF, the tools that follow the selection, the highlight toggle, a marker that marks once, and save paths.
  • OpenDocumentReaderTests: saves of a document, an empty edit, a text file and PDF marks.
  • 88 unit tests pass on the iPhone 17 Pro simulator (iOS 26.0). The Lite and Screenshots schemes build.

andiwand and others added 4 commits September 18, 2026 19:50
The engine moves to 7.0.0. While a document is edited a row of tools
grows under the bar: formatting, undo and redo for a text document,
undo and redo alone for a sheet, and five markers for a pdf, which is
saved with its marks. Presentations, Excel files and plain text edit
and save too.

The Lite app edits inside a paragraph. Formatting, new paragraphs and
marks on a pdf are Pro, and Lite offers Pro when they are reached for.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01214fGHJJ8jpfdujYBqDRsz
Every document is rendered with its editor, so the pencil only turns the
mode on and the page stays where it was. Leaving an edit asks about
saving only when the page holds a change. The refusals are said in
full, out-of-date formula cells are said once, and Lite's tools row
starts with a Pro badge. The gate has a flag of its own beside the ads
flag.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01214fGHJJ8jpfdujYBqDRsz
The website's viewer is the reference, and OpenDocument.droid #662 now
does the same.

- The pencil turns the edit on and off, and is drawn selected while it
  is on. A save button beside it writes the file. A save stays in the
  edit: the file is rendered again and the mode goes back on. Leaving
  with unsaved changes asks; leaving without them only turns the mode
  off.
- Each marker on a pdf has a colour of its own, picked with a chevron
  beside it. A marker pressed with text selected marks it once and
  leaves no tool armed.
- The highlight is a split button: a tap turns it on or off, and the
  chevron picks its colour.
- The colour bars and the text size follow the selection.
- The palettes are the ones the Android app offers. "Other color…"
  stays, because the website takes any colour.
- The notice about formula cells says how many, from a stringsdict in
  every language.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F6AQY2k86AaPq12nxBfN7A
A text file and a pdf now save and report their changes through the
core's own calls.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Si9aS96QtAu8r9rF8zQ7Xm
@andiwand andiwand changed the title Take odrcore 7.0.0, and put the editing tools under the bar Take odrcore 7.1.0, and put the editing tools under the bar Sep 19, 2026
@andiwand andiwand changed the title Take odrcore 7.1.0, and put the editing tools under the bar Take core 7.1.0, and put the editing tools under the bar Sep 19, 2026
Also keep a wide-gamut colour from the picker in range, and test the save
of a text file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Si9aS96QtAu8r9rF8zQ7Xm
@andiwand
andiwand marked this pull request as ready for review September 19, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant