fix(html): one text-decoration declaration for a run with two lines - #894
Merged
Merged
Conversation
The editing plans named inline formatting as the one open step and held one
sketch for it, `setMark {ids, mark, on}`, over four properties. The sketch
does not carry colour or size, because they are values and not toggles.
The document editing plan now has the section for it: seven properties and
where each format keeps them, the op `setTextStyle {id, style}`, decisions
8 to 16, the adapter surface, four steps of work and the open questions.
Two facts from the code shape it. A run shares its style container with its
siblings in all three writing engines, so a mark first gives the run a
container of its own. The renderer writes two `text-decoration`
declarations for a run that is both underlined and struck through, and the
second wins.
Formatting sits behind the editing scope: `paragraph` refuses it, and only
`document` takes it. The highlight question in editing.md is answered.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0137vd79NGaB8nfLsdPoghM4
`translate_text_style` wrote `text-decoration:underline;` and then `text-decoration:line-through;`, so a run that is both underlined and struck through showed one line, because the second declaration replaces the first. The two now share one declaration. No reference page holds both lines on one run, so no reference output changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0137vd79NGaB8nfLsdPoghM4
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Stacked on #893, step 1 of the inline formatting plan.
translate_text_stylewrotetext-decoration:underline;and thentext-decoration:line-through;. In css the second declaration replaces the first, so a run that is both underlined and struck through showed one line. The two now share one declaration,text-decoration:underline line-through;.The editor that lands later in this stack writes the css the renderer writes (decision 15 of
docs/design/document-editing.md), so the renderer had to write it right first.No reference page holds both lines on one run, so no reference output changes. Three tests on
translate_text_stylepin the three shapes. Changelog entry added.