Skip to content

fix: open mobile bottom drawers as named modal dialogs - #3645

Merged
JammingBen merged 5 commits into
opencloud-eu:mainfrom
jay23606:jay23606/ocdrop-mobile-bottom-drawer-dialog
Oct 13, 2026
Merged

JammingBen merged 5 commits into
opencloud-eu:mainfrom
jay23606:jay23606/ocdrop-mobile-bottom-drawer-dialog

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Description

Open the mobile bottom drawer as a native modal dialog so it receives focus, traps interaction, and exposes an accessible name to assistive technology. The menu drawer now uses its title when available and a translated “Menu” label otherwise.

Related Issue

How Has This Been Tested?

  • test environment: Node.js 22.21.0, pnpm 11.28.5, Windows
  • test case 1: Added tests verify the drawer opens with showModal(), has an accessible name, and closes when the active state changes.
  • test case 2: Added tests verify the mobile menu passes its title and uses a translated fallback label.
  • test case 3: Regression gate: the new tests failed on clean base twice and passed on the fix twice.
  • test case 4: Focused component tests (15 passed); design-system unit suite (487 passed); pnpm check:types passed; changed-file Prettier passed; changed-file ESLint reported zero errors and one existing warning.
  • Note: the root lint command's Windows glob and the project-wide format check also fail on the clean base.

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions)
  • Maintenance (like dependency updates or tooling adjustments)

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces 2 issues:

  1. the dim is cut of on the right side, see:
Image
  1. Modals are now behind the bottom drawer: click on a 3-dots-menu for any resource, click "Share" and then "Add link". The modal should be at the very top.

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JammingBen
JammingBen merged commit 3f9b1ed into opencloud-eu:main Oct 13, 2026
31 checks passed
openclouders pushed a commit that referenced this pull request Oct 13, 2026
…drawer-dialog

fix: open mobile bottom drawers as named modal dialogs
@openclouders openclouders mentioned this pull request Oct 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom drawers of OcDrop are not modal and don't take the focus

2 participants