Skip to content

fix(groups): include required label filter in transitive group search - #315

Merged
steipete merged 2 commits into
openclaw:mainfrom
salmonumbrella:fix/groups-list-query-304
Mar 7, 2026
Merged

steipete merged 2 commits into
openclaw:mainfrom
salmonumbrella:fix/groups-list-query-304

Conversation

@salmonumbrella

@salmonumbrella salmonumbrella commented Feb 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • fix groups list Cloud Identity query to include required group labels predicates alongside member_key_id
  • add a dedicated query builder with single-quote escaping for member IDs
  • add regression tests to assert the exact query shape used by groups list

Why

Issue #304 reports gog groups list returning 400 badRequest: Request contains an invalid argument.

Cloud Identity searchTransitiveGroups now requires a query that includes both:

  • member_key_id
  • one or more label predicates ('...label...' in labels)

Previously, gogcli only sent member_key_id, which triggers the 400.

Fixes #304

Testing

  • attempted: go test ./...
  • result: fails due pre-existing compile errors on current main in internal/cmd/contacts_crud.go (unrelated to this PR)

@steipete
steipete force-pushed the fix/groups-list-query-304 branch from 56af72c to cc16ea5 Compare March 7, 2026 17:59
@steipete
steipete merged commit 752dae2 into openclaw:main Mar 7, 2026
2 of 5 checks passed
@steipete

steipete commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator

Landed via temp rebase onto main.

  • Gate: make fmt && make lint && make test && make ci
  • Land commit: cc16ea5
  • Merge commit: 752dae2

Thanks @salmonumbrella!

klodr pushed a commit to klodr/gogcli that referenced this pull request Apr 22, 2026
…openclaw#315)

* fix(groups): add required labels filter for list query

* fix(groups): land transitive label filter note (openclaw#315) (thanks @salmonumbrella)

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gog groups list return 400

2 participants