Repository navigation
build(deps): refresh clients and patch Go toolchain - #1337
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR patches the Go build toolchain and refreshes Google client libraries and tracking-worker dependencies. Example: Build gog using the repository’s recommended Go toolchain.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this maintainer-authored PR open: main still uses the older toolchain and dependencies, and exact-head CI passes with no blocking defect found. Priority: P2 Before mergeNone. Findings
Agent review detailsHow this fits togetherGo module and Docker pins control CLI builds, while pnpm manifests control the tracking worker’s development, validation, and deployment tools. flowchart TD
A[Go source and module pins] --> B[Go toolchain]
B --> C[CLI binary]
D[Docker builder] --> C
E[Worker source and pnpm lockfile] --> F[Worker tooling]
F --> G[Worker bundle]
H[CI checks] --> B
H --> F
Technical reviewBest possible solution: Land the consistent toolchain and dependency refresh with the changelog references and credit restored. Do we have a high-confidence way to reproduce the issue? The upstream advisory confirms the old toolchain is affected, but no application-level crash reproduction was supplied or run. Is this the best way to solve the issue? Updating the existing toolchain and package-manager owners is a focused solution that preserves the documented source minimum and existing safeguards. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against a21e80f33260. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 10:10 PM ET / November 14, 2026, 03:10 UTC. |
The previous Go build toolchain exposes reachable GO-2026-6859 in net/http. Use Go 1.27.4 for normal and Docker builds and Go 1.26.11 for the minimum-series CI job, preserving the documented go 1.26.0 source minimum. The Docker image digest was checked against the registry manifest.
Refresh the Google clients and networking modules, regenerate go.sum, and refresh the tracking-worker tools and lockfile. Keep the existing package manager, runtime floors, 24-hour release cooldown, and security overrides. No project version bump or publication.
Validation: full make ci, frozen worker install and make worker-ci, and govulncheck ./... on one AWS Crabbox lease. Independent P0–P2 review returned scoped-clean. Exact-head GitHub CI and a merged-main release dry run are required before closeout.