Skip to content

build(deps): refresh clients and patch Go toolchain - #1337

Merged
steipete merged 1 commit into
mainfrom
build/round20-deps
Nov 14, 2026
Merged

steipete merged 1 commit into
mainfrom
build/round20-deps

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

The previous Go build toolchain exposes reachable GO-2026-6859 in net/http. Use Go 1.27.4 for normal and Docker builds and Go 1.26.11 for the minimum-series CI job, preserving the documented go 1.26.0 source minimum. The Docker image digest was checked against the registry manifest.

Refresh the Google clients and networking modules, regenerate go.sum, and refresh the tracking-worker tools and lockfile. Keep the existing package manager, runtime floors, 24-hour release cooldown, and security overrides. No project version bump or publication.

Validation: full make ci, frozen worker install and make worker-ci, and govulncheck ./... on one AWS Crabbox lease. Independent P0–P2 review returned scoped-clean. Exact-head GitHub CI and a merged-main release dry run are required before closeout.

@steipete
steipete requested a review from a team as a code owner November 14, 2026 02:57
@clawsweeper

clawsweeper Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T02:58:19.238268Z 956691c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Nov 14, 2026
@clawsweeper

clawsweeper Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR patches the Go build toolchain and refreshes Google client libraries and tracking-worker dependencies.

Example: Build gog using the repository’s recommended Go toolchain.

  • Before: The recommended toolchain and Docker builder use Go 1.27.3.
  • After: Both use Go 1.27.4, while minimum-series CI uses Go 1.26.11.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The focused patch has passing exact-head platform and worker validation; evidence remains build/test based rather than an exercised application workflow.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored dependency and build maintenance adds no application workflow requiring shipped-entry-point proof; exact-head CI validates the updated build and test paths.
Patch quality 🐚 platinum hermit (4/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: CLI builds still use a Go toolchain covered by a published security advisory.
Reason: The maintainer-authored refresh follows the existing dependency-maintenance pattern and selects the upstream fixed Go versions.

Merge readiness

✅ Ready for maintainer review

Keep this maintainer-authored PR open: main still uses the older toolchain and dependencies, and exact-head CI passes with no blocking defect found.

Priority: P2
Reviewed head: 956691c1c6e7128a4640140af11641f677fdf49c

Before merge

None.

Findings

  • [P3] Add the required changelog references and contributor credit — CHANGELOG.md:5-6
Agent review details

How this fits together

Go module and Docker pins control CLI builds, while pnpm manifests control the tracking worker’s development, validation, and deployment tools.

flowchart TD
  A[Go source and module pins] --> B[Go toolchain]
  B --> C[CLI binary]
  D[Docker builder] --> C
  E[Worker source and pnpm lockfile] --> F[Worker tooling]
  F --> G[Worker bundle]
  H[CI checks] --> B
  H --> F
Loading

Technical review

Best possible solution:

Land the consistent toolchain and dependency refresh with the changelog references and credit restored.

Do we have a high-confidence way to reproduce the issue?

The upstream advisory confirms the old toolchain is affected, but no application-level crash reproduction was supplied or run.

Is this the best way to solve the issue?

Updating the existing toolchain and package-manager owners is a focused solution that preserves the documented source minimum and existing safeguards.

Full review comments:

  • [P3] Add the required changelog references and contributor credit — CHANGELOG.md:5-6
    Both new Unreleased entries omit a PR reference and contributor thanks, which root AGENTS.md explicitly requires. Add the reference to this PR and the appropriate credit so the release notes retain traceability; this is nonblocking.
    Confidence: 0.99

Overall correctness: patch is correct
Overall confidence: 0.94

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against a21e80f33260.

Provenance checked

  • Go toolchain, Docker, minimum-series CI, and install documentation keeps the original intent (8e92345: Patch the build toolchain while preserving the Go 1.26.0 source minimum and matching Docker configuration.)
  • Go clients and worker dependency manifests keeps the original intent (efa67af: Refresh supported clients and tooling while retaining package-manager pins, cooldown policy, and security overrides.)
  • Worker runtime security override keeps the original intent (1d0d4d2: Select a patched local workerd engine that rejects compromised certificate keys even with explicit historical roots.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 71387b3 adds internal/tracking/worker/pnpm-workspace.yaml:5 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 71387b3bea66; files: internal/tracking/worker/pnpm-workspace.yaml)
  • Josh Avant: Raw commit ea58260 adds .github/workflows/ci.yml:63 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: ea582609ec6e; files: .github/workflows/ci.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P2: This is useful security and dependency maintenance, with no demonstrated urgent application failure or introduced regression.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: This is useful security and dependency maintenance, with no demonstrated urgent application failure or introduced regression.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 13, 2026, 10:10 PM ET / November 14, 2026, 03:10 UTC.

@steipete
steipete merged commit 6d97417 into main Nov 14, 2026
17 checks passed
@steipete
steipete deleted the build/round20-deps branch November 14, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant