Repository navigation
fix: preserve workspace request and output contracts - #1336
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR repairs pagination, recipient selection, request serialization, and output contracts across existing Google Workspace commands. Example: A Gmail watch notification covers history pages containing m1 and m2, with mailbox historyId 300.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR fixes concrete request and output defects still present on main; review found no actionable patch defect. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe command layer translates CLI arguments into authenticated Google API requests, then formats responses or delivers Gmail watch payloads to hooks. flowchart LR
A[CLI arguments] --> B[Command validation and planning]
B --> C[Google API clients]
C --> D[Response pagination and normalization]
D --> E[JSON or table output]
D --> F[Gmail watch processor]
F --> G[Hook delivery and cursor state]
Technical reviewBest possible solution: Land the existing contract repairs with their regression coverage, documented compatibility changes, and contributor credits. Do we have a high-confidence way to reproduce the issue? Main source establishes the one-page watch cursor loss, wrong recurring-parent target, omitted explicit clears, and float64 append conversion; linked reports supply failing regressions and CLI traces, while this read-only review ran no target code. Is this the best way to solve the issue? The patch fixes the demonstrated command and shared-helper boundaries directly, preserving existing request owners and avoiding new flags or parallel implementations. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6f910fffac0a. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 9:55 PM ET / November 14, 2026, 02:55 UTC. |
Problem and change
Several existing commands silently dropped data or sent a different request than the caller intended. This consolidates the verified fixes from #1308, #1311–#1319, #1321–#1326, plus issues #1328–#1329, #1330–#1331 and #1335.
@, and malformed attendee clears.The Contacts search default matches Google's effective 30-result ceiling; larger requested limits continue with a warning. Default auto-replies stop when alias discovery fails, because the documented self-exclusion cannot be guaranteed;
--allow-selfkeeps the earlier fallback. No release, version, scope or security-setting changes.Validation
The regression tests failed against main before the production fixes. They exercise the actual command dispatcher or command/API boundary against synthetic HTTP responses, including serialized requests, MIME, pagination and output. Provider-side behavior is not claimed as live-tested.
make cipassed on AWS Crabboxcbx_7b5d005c5d91(runrun_997659e86efc486cc73493aec1567b3d): formatting, lint, deadcode, full tests, docs and generated skills. Two independent P0–P2 reviews returned scoped-clean. A built macOS CLI also passed loopback request checks for all four new validation/precision issues. The Docs terminal-list inheritance issue (#1333), affected-account OAuth consent issue (#1334), opaque Gmail URL feature (#1327), Chat attachments (#1320), recurrence policy (#1309), and pre-existing holds remain separate.Thanks to @saariuslystoned, @SebTardif, @privatenumber, @pkyIntelligence and @henkisdabro.