Repository navigation
fix(auth): preserve read-only Calendar grants during reauthorization - #1265
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic reauthorization of a Calendar read-only token could ask Google to include permissions from an earlier, broader grant. Detect the stored Calendar read-only scope and omit incremental grants, including for mixed-service tokens and tokens that also allow event writes. Full Calendar grants retain the existing behavior.
Adds authorization-URL regression coverage and documents the behavior. Thanks @pkyIntelligence for the reproduction in #1259; the separate narrower-write-preset proposal remains open.
Validation:
go test ./internal/googleauth -run TestReauth -count=1,make ci, and independent Codex review (no actionable findings).