Skip to content

fix(auth): preserve read-only Calendar grants during reauthorization - #1265

Merged
steipete merged 1 commit into
mainfrom
fix/calendar-reauth-1259
Oct 26, 2026
Merged

steipete merged 1 commit into
mainfrom
fix/calendar-reauth-1259

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Automatic reauthorization of a Calendar read-only token could ask Google to include permissions from an earlier, broader grant. Detect the stored Calendar read-only scope and omit incremental grants, including for mixed-service tokens and tokens that also allow event writes. Full Calendar grants retain the existing behavior.

Adds authorization-URL regression coverage and documents the behavior. Thanks @pkyIntelligence for the reproduction in #1259; the separate narrower-write-preset proposal remains open.

Validation: go test ./internal/googleauth -run TestReauth -count=1, make ci, and independent Codex review (no actionable findings).

@clawsweeper

clawsweeper Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T12:05:04.894107Z 5585536 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@steipete
steipete merged commit 4d68f06 into main Oct 26, 2026
11 checks passed
@steipete
steipete deleted the fix/calendar-reauth-1259 branch October 26, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant