Skip to content

build(deps): refresh policy-eligible worker dependencies - #1178

Merged
steipete merged 2 commits into
mainfrom
oss-s7-gogcli-deps
Oct 1, 2026
Merged

steipete merged 2 commits into
mainfrom
oss-s7-gogcli-deps

Conversation

@steipete

@steipete steipete commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Update the tracking worker to Wrangler 4.144.0 and Cloudflare Workers types 5.20260930.1, including Wrangler’s required Miniflare patch. Both direct releases have cleared the existing 24-hour cooldown. Retain pnpm 11.28.2, the Go 1.26 floor, and the existing worker runtime compatibility.

Validation: frozen-lockfile install, worker lint/typecheck/dry build and 15 tests, full make ci on AWS Crabbox, and independent review through P2. Exact-head cross-platform CI must pass before merge.

Newer Wrangler, Vitest, and Workers types releases remain inside the cooldown. The pnpm 12 migration is outside this focused update.

@clawsweeper

clawsweeper Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 1, 2026
@clawsweeper

clawsweeper Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed September 30, 2026, 10:36 PM ET / October 1, 2026, 02:36 UTC.

ClawSweeper review

What this changes

The PR updates the email-tracking worker’s Wrangler tooling, Cloudflare type definitions, and required Miniflare patch, with an Unreleased changelog entry.

Merge readiness

✅ Ready for maintainer review

The update remains useful because current main still pins the older dependencies. No actionable defect was found in the focused patch, and the collaborator-authored PR should remain open for normal merge checks.

Priority: P3
Reviewed head: 8319e67ba0d6d35ff6dba101106632011e1373c0

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, internally consistent dependency refresh with reported validation and no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: The collaborator-authored tooling refresh is exempt from external-contributor runtime proof. Reported worker build and test checks are supplemental; no authority or stored-data contract changes require separate proof.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The collaborator-authored tooling refresh is exempt from external-contributor runtime proof. Reported worker build and test checks are supplemental; no authority or stored-data contract changes require separate proof.
Evidence reviewed 8 items Pinned introduced patch: The verified main-to-head delta changes only CHANGELOG.md, package.json, and pnpm-lock.yaml. Manifest versions, importer entries, package resolutions, and dependency snapshots agree; the verified test-merge result has the same three-file scope.
Still necessary on current main: Current main specifies Workers types 5.20260929.1 and Wrangler 4.143.0, whereas the proposed versions are 5.20260930.1 and 4.144.0.
Registry provenance and required dependency: Read-only npm registry inspection identified cloudflare/workers-sdk as Wrangler and Miniflare’s source repository. Wrangler 4.144.0 was published 2026-09-29T21:12:31.087Z and requires Miniflare 5.20260926.1-alpha, published 2026-09-29T15:21:48.048Z. Both registry integrity values match the introduced lockfile, and both require Node >=22. Sources: https://registry.npmjs.org/wrangler and https://registry.npmjs.org/miniflare.
Findings None None.
Security None None.

How this fits together

The tracking worker receives email-pixel requests and stores open events in Cloudflare D1. Wrangler builds and deploys this worker, while Cloudflare type definitions support its TypeScript checks.

flowchart LR
  A[Dependency manifest] --> B[Locked worker tooling]
  B --> C[Typecheck and build]
  C --> D[Cloudflare worker]
  E[Email pixel requests] --> D
  D --> F[D1 open records]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

None.

Technical review

Best possible solution:

Keep the dependency refresh narrow while preserving the existing runtime compatibility and installation safeguards.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this dependency-maintenance PR does not report a runtime defect.

Is this the best way to solve the issue?

Yes: the manifest and lockfile update is focused, matches registry metadata, and preserves existing tooling and runtime controls.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 3dd0bf1a3e0d.

Labels

Label changes:

  • add P3: This is a bounded tooling refresh with no changed application behavior or demonstrated urgent regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling refresh is exempt from external-contributor runtime proof. Reported worker build and test checks are supplemental; no authority or stored-data contract changes require separate proof.

Label justifications:

  • P3: This is a bounded tooling refresh with no changed application behavior or demonstrated urgent regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored tooling refresh is exempt from external-contributor runtime proof. Reported worker build and test checks are supplemental; no authority or stored-data contract changes require separate proof.

Evidence

What I checked:

  • Pinned introduced patch: The verified main-to-head delta changes only CHANGELOG.md, package.json, and pnpm-lock.yaml. Manifest versions, importer entries, package resolutions, and dependency snapshots agree; the verified test-merge result has the same three-file scope. (internal/tracking/worker/package.json:16, 8319e67ba0d6)
  • Still necessary on current main: Current main specifies Workers types 5.20260929.1 and Wrangler 4.143.0, whereas the proposed versions are 5.20260930.1 and 4.144.0. (internal/tracking/worker/package.json:16, 3dd0bf1a3e0d)
  • Registry provenance and required dependency: Read-only npm registry inspection identified cloudflare/workers-sdk as Wrangler and Miniflare’s source repository. Wrangler 4.144.0 was published 2026-09-29T21:12:31.087Z and requires Miniflare 5.20260926.1-alpha, published 2026-09-29T15:21:48.048Z. Both registry integrity values match the introduced lockfile, and both require Node >=22. Sources: https://registry.npmjs.org/wrangler and https://registry.npmjs.org/miniflare.
  • Workers types provenance: The npm registry identifies cloudflare/workerd as the Workers types source repository. Version 5.20260930.1 was published 2026-09-30T01:29:39.011Z, more than 24 hours before PR creation, and its integrity value matches the lockfile. Source: https://registry.npmjs.org/@cloudflare/workers-types.
  • Compatibility and supply-chain controls preserved: The patch leaves the 1440-minute release cooldown, build-script allowlist, dependency overrides, pnpm 11.28.2, Node 26 CI, worker compatibility date, worker source, and D1 schema unchanged. The changelog entry is under Unreleased. No new package source, permission, or install hook is introduced. (internal/tracking/worker/pnpm-workspace.yaml:5, 8319e67ba0d6)
  • Validation and author context: The captured body reports frozen-lockfile installation, worker lint/typecheck/dry build, 15 tests, and make ci on AWS Crabbox. The supplied worker check succeeded; cross-platform checks were still running. REST inspection confirmed the same head and body, COLLABORATOR association, and no submitted reviews or review comments. These are reported checks, not reviewer-executed validation. (8319e67ba0d6)

Likely related people:

  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@steipete
steipete merged commit 132b3ca into main Oct 1, 2026
13 checks passed
@steipete
steipete deleted the oss-s7-gogcli-deps branch October 1, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant