chore(release): prepare 1.1.0 - #62
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 24, 2026, 5:09 AM ET / 09:09 UTC. ClawSweeper reviewWhat this changesBumps the ESP-IDF component manifest to 1.1.0, finalizes the accumulated changelog, and documents registry and source-release delivery. Merge readiness⛔ Blocked before merge - 3 items remain Keep open. The 1.1.0 preparation is absent from main, but the getting-started guide presents the source release as available before the required manual publication has occurred. Priority: P2 Review scores
Verification
How this fits togetherThe component manifest identifies the ESP32 node library version. After release approval, a manual workflow uploads the core component to Espressif’s registry; a matching GitHub tag supplies the full source and room examples. flowchart TD
A[Source and release notes] --> B[Versioned component manifest]
B --> C{Release approved and qualified?}
C -->|Yes| D[Manual registry upload]
D --> E[Verify package identity]
E --> F[GitHub source release]
F --> G[User delivery guidance]
Decision needed
Why: The merged release-workflow decision requires separate approval for a new version and leaves the first live OIDC upload and archive verification to this release. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep the 1.1.0 preparation, describe artifacts as available only after publication, and have the release owner verify the registered archive before tagging the same source commit. Do we have a high-confidence way to reproduce the issue? Not applicable as a runtime bug. The premature release-availability claim is directly checkable: main still says 1.0.0, and GitHub has no v1.1.0 tag or Release. Is this the best way to solve the issue? No, as written. The manual release sequence fits the existing policy, but the getting-started guide must make artifact availability conditional until publication. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against b8c918d99b4f. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Prepare 1.1.0 for the accumulated session/surface APIs, Gateway protocol support, teardown and credential-handling fixes, and room build repairs. The new public APIs make this a minor release. Finalize all 17 changelog entries with highlights and contributor credit, retain an empty Unreleased section, and align delivery documentation with the core registry package and full source release.
Host validation on AWS Crabbox passed: 112 script tests with no skips; five real filesystem scenarios; 19 Talk routing/adapter cases; 24 pthread lifetime cases and public-layout checks; 12 exchanges through the actual ESP-IDF Linux HTTP client, with no requests following any redirect. The release checker’s 11 tests and public 1.1.0 absence preflight passed. Codex autoreview is scoped-clean at P0–P2.
After this PR passes all firmware jobs and release validation, publication uses the existing manual OIDC workflow on main. The registered ZIP’s version, repository, component path, and commit SHA must match before creating the matching GitHub tag and Release with the changelog section verbatim.
Hardware qualification was not performed: no flashing, on-device Unity execution, live Gateway pairing/reconnect, acoustic wake/Talk, display/Canvas, camera/DMA, SD-card removal, or C6 coprocessor qualification. Firmware CI plus host checks are the accepted release gate.
Final gate: all five firmware jobs, release validation, and CodeQL passed at exact head
9f2719f5fe74fb5aef641f12045463b31686c9c3.