Repository navigation
Host screenshots as user attachments and keep release pages APK-only - #92
Merged
Merged
Conversation
Contributor
Screenshots
Captured from the demo build at 26e49eb. |
Collaborator
Author
|
I still see asset on the helper release: Screenshots Assets |
Contributor
Screenshots
Captured from the demo build at 2c6a539. |
Collaborator
Author
|
Ok, but I still see screenshot-sheet-2c6a539.png asset on the helper release: https://github.com/dzid26/TeslaBatteryBLE/releases/tag/screenshots I though we are using undocumented uplodaing api directly to sheet. |
dzid26
marked this pull request as draft
October 6, 2026 14:56
dzid26
marked this pull request as ready for review
October 6, 2026 15:26
Contributor
Screenshots
Captured from the demo build at 183bc27. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows your decisions: native attachments first, and the standard sticky-comment action.\n\n- New .github/scripts/upload-screenshot.sh: uploads a PNG via GitHub's user-attachments endpoint (the drag-and-drop one; live-tested with the repo token, it returned a real \github.com/user-attachments/assets/...\ URL) and prints the URL. If the endpoint rejects the token it falls back to an asset on a hidden \screenshots\ release, so an embed URL always exists.\n- \publish-preview-release.sh\ / \publish-tag-release.sh: embed the attachment URL in the notes and upload only the APK — release pages no longer carry screenshot assets.\n- \preview-health.yml: asserts the APK + a screenshot image in the notes (and staleness by the APK), instead of a sheet asset.\n- \pr-screenshots.yml: posts one self-updating comment with \ hollander/actions-comment-pull-request\ pinned to v3.0.1 (\24bffb9b…, the action openpilot uses) and a \comment-tag, replacing the hand-rolled comment PATCHing; the sheet comes from the helper.\n\nUntested until the first CI run: whether the Actions \GITHUB_TOKEN\ is accepted by the attachments endpoint — the release-asset fallback covers it either way. Bash syntax checked locally. Review before merge.