Skip to content

refactor: drop the BatterySample.percent alias for batteryLevel - #322

Merged
dzid26 merged 1 commit into
mainfrom
claude/project-thread-dm5q8m
Oct 21, 2026
Merged

dzid26 merged 1 commit into
mainfrom
claude/project-thread-dm5q8m

Conversation

@dzid26

@dzid26 dzid26 commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Requested by R · project thread

Summary

BatterySample.percent was a pure alias of batteryLevel (the "smaller leftovers" item in #122). Two names for one value made readers wonder whether they differ. The alias is removed and its callers use batteryLevel: chargeStats and ChargeProjection in :core, Projected.kt and BleModels.kt in :app. Other percent names (the chart's TimePoint, the demo Point types, the notification model) are different types and stay.

Type

  • Refactor (no behavior change)

Testing

:core compiles and its main and test sources build locally. The Android SDK and part of Maven Central are unavailable in this session, so the :app edits (three one-line changes) were found by search and are checked by CI only.

  • ./gradlew :protocol:test :core:test
  • ./gradlew :app:testDebugUnitTest
  • ./gradlew :app:lintDebug

Checklist

  • No VINs, keys, or decrypted payloads in logs
  • Docs and ADRs affected by this change are updated (none affected)

Generated by Claude Code

@dzid26 dzid26 self-assigned this Oct 21, 2026
@dzid26
dzid26 marked this pull request as ready for review October 21, 2026 14:22
@dzid26
dzid26 merged commit 239bb90 into main Oct 21, 2026
17 checks passed
@dzid26
dzid26 deleted the claude/project-thread-dm5q8m branch October 21, 2026 14:22
@github-actions

Copy link
Copy Markdown
Contributor

Snapshots

No visual change in the snapshots at 7ec2c9c (vs 78054b4).

Debug APK: zip from Android CI (GitHub sign-in needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants