Repository navigation
refactor: drop the BatterySample.percent alias for batteryLevel - #322
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015dJ9erFWvKUmJi9waSre1P
Contributor
SnapshotsNo visual change in the snapshots at 7ec2c9c (vs 78054b4). Debug APK: zip from Android CI (GitHub sign-in needed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by R · project thread
Summary
BatterySample.percentwas a pure alias ofbatteryLevel(the "smaller leftovers" item in #122). Two names for one value made readers wonder whether they differ. The alias is removed and its callers usebatteryLevel:chargeStatsandChargeProjectionin:core,Projected.ktandBleModels.ktin:app. Otherpercentnames (the chart'sTimePoint, the demoPointtypes, the notification model) are different types and stay.Type
Testing
:corecompiles and its main and test sources build locally. The Android SDK and part of Maven Central are unavailable in this session, so the:appedits (three one-line changes) were found by search and are checked by CI only../gradlew :protocol:test :core:test./gradlew :app:testDebugUnitTest./gradlew :app:lintDebugChecklist
Generated by Claude Code