Repository navigation
fix: skip RSSI reads while a GATT write or setup step is in flight - #234
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
SnapshotsNo visual change in the snapshots at 208701a (vs c168259). Full-screen emulator shots: Actions → Debug APK: still building in Android CI (GitHub sign-in needed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by R
Before:
readRssi()could issuereadRemoteRssi()while a characteristic write or a setup step was outstanding, breaking the one-GATT-operation-at-a-time rule. The write-type comment claimed a validation that isn't recorded anywhere.After: RSSI reads are skipped while setup isn't done or a write is in flight (the next poll picks it up). The comment now says why we write without response.
How: guard in
TeslaGattClient.readRssi. The rest of #110 (main-thread callbacks, serialized setup) already landed in 5bf55cc. Compiles; ktlint's worker daemon crashed locally, so CI is the lint check.Closes #110
🤖 Generated with Claude Code