Repository navigation
Shrink card snapshots, move screens to a tall device - #205
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dzid26
force-pushed
the
work/paparazzi-shrink-and-tall
branch
from
October 12, 2026 00:34
6731841 to
1b2a4ea
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
SnapshotsNo visual change in the snapshots at d25bf9a (vs 1b2a4ea). Full-screen emulator shots: Actions → Debug APK: still building in Android CI (GitHub sign-in needed) |
This was referenced Oct 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only follow-up to #194: cards render SHRINK-wrapped, screens move to a tall phone.
snapCard):RenderingMode.SHRINKon the default NEXUS_5 device, so bitmaps come out full-width x content-height (1000x311..664 depending on state) with no black void. Card width is unchanged, only the void goes away.snapScreen): full-device NORMAL mode on the Pixel 7 Pro preset (1440x3120, 19.5:9 portrait — the exact S24-Ultra-like match in this Paparazzi version), giving scrolled content vertical room.<card>_<state>_light/dark.png,screen-*_light/dark.png), so thepr-paparazzibyte-compare flow needs no changes. No workflow/script/doc changes in this PR.Implementation note: the brief asked for a second Paparazzi rule for the cards, but two rules cannot coexist in one class on Paparazzi 2.0.0-alpha05.1 — layoutlib acquires a single scene per thread, so the nested rules fail every test with
IllegalStateException: Acquiring different scenes from same thread without releases(verified). The version-correct equivalent is one rule plusunsafeUpdateConfig(deviceConfig, renderingMode)at the top of each helper; each helper sets both values every call, so renders never depend on test order.CONSEQUENCE: the first PR run after merge will post ALL snapshots as changed because dimensions change — one noisy round, expected, then quiet.
Verify:
:app:recordPaparazziDebuggreen; fresh--rerun-tasksre-record from zero is byte-identical across all 30 PNGs (SHRINK sizing is deterministic for the byte-compare diff flow).:core:test :app:testDebugUnitTest :app:lintDebug ktlintCheck detektgreen. No workflow/script changes, so actionlint is unaffected.