Skip to content

Tolerate whitespace in the shared CI debug key variable - #141

Merged
dzid26 merged 1 commit into
mainfrom
work/ci-debug-key-whitespace
Oct 8, 2026
Merged

dzid26 merged 1 commit into
mainfrom
work/ci-debug-key-whitespace

Conversation

@dzid26

@dzid26 dzid26 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

The build job decodes the CI_DEBUG_KEYSTORE_BASE64 repository variable (from #139) with base64 -d. A value pasted on Windows ends in CRLF, and base64 -d rejects the carriage return with base64: invalid input. That failed the build job before it produced an APK (seen on the #133/#138 re-runs). This PR strips all whitespace before decoding, which also accepts line-wrapped encoder output such as certutil's.

One line in .github/workflows/android.yml, plus a comment.

Type

  • Bug fix
  • Feature
  • Protocol / crypto change
  • Docs / CI / tooling
  • Refactor (no behavior change)

Testing

  • Reproduced the failure locally: the old pipeline fails on the value with a trailing \r\n.
  • The new pipeline decodes a plain value, a CRLF-terminated value, and a 64-column CRLF-wrapped value to a byte-identical keystore.
  • actionlint is clean on android.yml.
  • No app code changes, so the screenshot job doesn't run.

Checklist

  • Protocol changes ship test vectors; expected.txt regenerated, not hand-edited (n/a)
  • No VINs, keys, or decrypted payloads in logs (the variable holds a throwaway debug key and was never a secret)
  • Docs/master-plan updated where relevant (n/a)
  • New source files carry SPDX-License-Identifier: AGPL-3.0-only (no new files)

🤖 Generated with Claude Code

https://claude.ai/code/session_0129RzhbEE2cboMcYyZMuxqX


Generated by Claude Code

A value pasted on Windows ends in CRLF, and base64 -d rejects the
carriage return ("invalid input"), which failed the build job before
it produced an APK. Strip all whitespace before decoding; this also
accepts line-wrapped encoder output such as certutil's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0129RzhbEE2cboMcYyZMuxqX
@dzid26
dzid26 merged commit 9fd4af2 into main Oct 8, 2026
5 checks passed
@dzid26
dzid26 deleted the work/ci-debug-key-whitespace branch October 8, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants