Repository navigation
Preserve Windows startup variables and MXC child environment defaults - #54027
Merged
copyberry[bot] merged 1 commit intoOct 14, 2026
Conversation
…#54027) ## Why Windows MXC needs valid host startup variables, while an empty child environment must remain empty for the SDK to select Windows user-profile defaults. ## What changed - Replace caller overrides of `SystemDrive` and `LOCALAPPDATA` case-insensitively with nonempty Unicode host values, failing before launch if either is unavailable. - Track whether the original child environment was empty, ignoring launcher transport keys. Supply host `SystemRoot` for launcher bootstrap in that case, then clear the bootstrap environment before the SDK selects defaults. ## Testing Extend transport tests to cover host-value replacement and preservation of empty child environments. Strengthen the PowerShell fallback RPC test to require `SystemDrive`, `LOCALAPPDATA`, `USERPROFILE`, and `PATH` in the child. GitOrigin-RevId: a097e1079069ef897ebb5ba5e63546328c5faeaa
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa
branch
from
October 14, 2026 16:31
9199844 to
81aee8c
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa
branch
October 14, 2026 16:31
FxckingAngel
temporarily deployed
to
issue-triage
October 14, 2026 16:36 — with
GitHub Actions
Inactive
FxckingAngel
temporarily deployed
to
issue-triage
October 14, 2026 16:36 — with
GitHub Actions
Inactive
FxckingAngel
temporarily deployed
to
issue-triage
October 14, 2026 16:36 — with
GitHub Actions
Inactive
laotoutou
temporarily deployed
to
issue-triage
October 14, 2026 16:37 — with
GitHub Actions
Inactive
laotoutou
temporarily deployed
to
issue-triage
October 14, 2026 16:37 — with
GitHub Actions
Inactive
laotoutou
temporarily deployed
to
issue-triage
October 14, 2026 16:37 — with
GitHub Actions
Inactive
agreenPD85
temporarily deployed
to
issue-triage
October 14, 2026 16:38 — with
GitHub Actions
Inactive
agreenPD85
temporarily deployed
to
issue-triage
October 14, 2026 16:38 — with
GitHub Actions
Inactive
agreenPD85
temporarily deployed
to
issue-triage
October 14, 2026 16:38 — with
GitHub Actions
Inactive
agreenPD85
temporarily deployed
to
issue-triage
October 14, 2026 16:39 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Windows startup variables and MXC child environment defaults
Why
Windows MXC needs valid host startup variables, while an empty child environment must remain empty for the SDK to select Windows user-profile defaults.
What changed
SystemDriveandLOCALAPPDATAcase-insensitively with nonempty Unicode host values, failing before launch if either is unavailable.SystemRootfor launcher bootstrap in that case, then clear the bootstrap environment before the SDK selects defaults.Testing
Extend transport tests to cover host-value replacement and preservation of empty child environments. Strengthen the PowerShell fallback RPC test to require
SystemDrive,LOCALAPPDATA,USERPROFILE, andPATHin the child.