Skip to content

Preserve Windows startup variables and MXC child environment defaults - #54027

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa
Oct 14, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Preserve Windows startup variables and MXC child environment defaults

Why

Windows MXC needs valid host startup variables, while an empty child environment must remain empty for the SDK to select Windows user-profile defaults.

What changed

  • Replace caller overrides of SystemDrive and LOCALAPPDATA case-insensitively with nonempty Unicode host values, failing before launch if either is unavailable.
  • Track whether the original child environment was empty, ignoring launcher transport keys. Supply host SystemRoot for launcher bootstrap in that case, then clear the bootstrap environment before the SDK selects defaults.

Testing

Extend transport tests to cover host-value replacement and preservation of empty child environments. Strengthen the PowerShell fallback RPC test to require SystemDrive, LOCALAPPDATA, USERPROFILE, and PATH in the child.

…#54027)

## Why

Windows MXC needs valid host startup variables, while an empty child environment must remain empty for the SDK to select Windows user-profile defaults.

## What changed

- Replace caller overrides of `SystemDrive` and `LOCALAPPDATA` case-insensitively with nonempty Unicode host values, failing before launch if either is unavailable.
- Track whether the original child environment was empty, ignoring launcher transport keys. Supply host `SystemRoot` for launcher bootstrap in that case, then clear the bootstrap environment before the SDK selects defaults.

## Testing

Extend transport tests to cover host-value replacement and preservation of empty child environments. Strengthen the PowerShell fallback RPC test to require `SystemDrive`, `LOCALAPPDATA`, `USERPROFILE`, and `PATH` in the child.

GitOrigin-RevId: a097e1079069ef897ebb5ba5e63546328c5faeaa
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa branch from 9199844 to 81aee8c Compare October 14, 2026 16:31
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-14T16:31:19.037962Z 9199844 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 81aee8c into main Oct 14, 2026
4 of 5 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/a097e1079069ef897ebb5ba5e63546328c5faeaa branch October 14, 2026 16:31
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — 81aee8c8 Deployed Oct 14, 2026 by Bonitto via Generate label suggestions #55484
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants