Skip to content

Cancel Guardian V2 classifications that exceed the tool-call lag window - #53699

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Cancel Guardian V2 classifications that exceed the tool-call lag window

Why

Pending classifications can outlive the max_tool_call_lag window in which their scores are reusable, keeping metadata waits or classifier transports active after the result becomes stale.

What changed

  • Expire pending classifications when tool-call progress exceeds the configured lag allowance, preserving the wrapper discount while nested code-mode actions remain active.
  • Cancel metadata waits and sampling in snapshot and conversation modes, including snapshot response drains after an early score.
  • Treat expiry as supersession, preserving cached scores and the last completed conversation checkpoint and transcript cursor.

Testing

Add regression coverage for lag boundaries, active wrapper discounts, transport cancellation before and after early scores, expired requests skipping preparation, and conversation history and transcript deltas surviving cancellation.

…ow (#53699)

## Why

Pending classifications can outlive the `max_tool_call_lag` window in which their scores are reusable, keeping metadata waits or classifier transports active after the result becomes stale.

## What changed

- Expire pending classifications when tool-call progress exceeds the configured lag allowance, preserving the wrapper discount while nested code-mode actions remain active.
- Cancel metadata waits and sampling in snapshot and conversation modes, including snapshot response drains after an early score.
- Treat expiry as supersession, preserving cached scores and the last completed conversation checkpoint and transcript cursor.

## Testing

Add regression coverage for lag boundaries, active wrapper discounts, transport cancellation before and after early scores, expired requests skipping preparation, and conversation history and transcript deltas surviving cancellation.

GitOrigin-RevId: 892ff13a05fd2b1573cef9842b934d1fc865d951
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951 branch from c61d9a6 to f6aca7d Compare October 13, 2026 15:25
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T15:25:26.881424Z c61d9a6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit f6aca7d into main Oct 13, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951 branch October 13, 2026 15:25
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — f6aca7dc Deployed Oct 13, 2026 by Amoszhao001 via Generate label suggestions #55119
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants