Repository navigation
Cancel Guardian V2 classifications that exceed the tool-call lag window - #53699
Merged
copyberry[bot] merged 1 commit intoOct 13, 2026
Conversation
…ow (#53699) ## Why Pending classifications can outlive the `max_tool_call_lag` window in which their scores are reusable, keeping metadata waits or classifier transports active after the result becomes stale. ## What changed - Expire pending classifications when tool-call progress exceeds the configured lag allowance, preserving the wrapper discount while nested code-mode actions remain active. - Cancel metadata waits and sampling in snapshot and conversation modes, including snapshot response drains after an early score. - Treat expiry as supersession, preserving cached scores and the last completed conversation checkpoint and transcript cursor. ## Testing Add regression coverage for lag boundaries, active wrapper discounts, transport cancellation before and after early scores, expired requests skipping preparation, and conversation history and transcript deltas surviving cancellation. GitOrigin-RevId: 892ff13a05fd2b1573cef9842b934d1fc865d951
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951
branch
from
October 13, 2026 15:25
c61d9a6 to
f6aca7d
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/892ff13a05fd2b1573cef9842b934d1fc865d951
branch
October 13, 2026 15:25
Amoszhao001
temporarily deployed
to
issue-triage
October 13, 2026 15:33 — with
GitHub Actions
Inactive
Amoszhao001
temporarily deployed
to
issue-triage
October 13, 2026 15:33 — with
GitHub Actions
Inactive
Amoszhao001
temporarily deployed
to
issue-triage
October 13, 2026 15:33 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel Guardian V2 classifications that exceed the tool-call lag window
Why
Pending classifications can outlive the
max_tool_call_lagwindow in which their scores are reusable, keeping metadata waits or classifier transports active after the result becomes stale.What changed
Testing
Add regression coverage for lag boundaries, active wrapper discounts, transport cancellation before and after early scores, expired requests skipping preparation, and conversation history and transcript deltas surviving cancellation.