Skip to content

Improve remote exec-server test startup diagnostics - #53668

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/75739fc93d7f28ba0a3f447a14d4d20b2dbdfd14
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/75739fc93d7f28ba0a3f447a14d4d20b2dbdfd14

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Improve remote exec-server test startup diagnostics

Why

The remote exec-server parent-lifetime test can hide an early process exit behind a connection timeout, making startup failures harder to diagnose.

What changed

  • Race the WebSocket connection against the child process exiting so startup exits are reported immediately.
  • Include the registration request count and child status when attachment fails, without inspecting request headers or bodies containing authentication data.
  • Enable remote exec-server info logging in the test while keeping other logs at error level.

## Why

The remote exec-server parent-lifetime test can hide an early process exit behind a connection timeout, making startup failures harder to diagnose.

## What changed

- Race the WebSocket connection against the child process exiting so startup exits are reported immediately.
- Include the registration request count and child status when attachment fails, without inspecting request headers or bodies containing authentication data.
- Enable remote exec-server info logging in the test while keeping other logs at error level.

GitOrigin-RevId: 75739fc93d7f28ba0a3f447a14d4d20b2dbdfd14
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/75739fc93d7f28ba0a3f447a14d4d20b2dbdfd14 branch from 5cff2c5 to a68a7a6 Compare October 13, 2026 13:26
@copyberry
copyberry Bot merged commit a68a7a6 into main Oct 13, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T13:26:34.166812Z 5cff2c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/75739fc93d7f28ba0a3f447a14d4d20b2dbdfd14 branch October 13, 2026 13:26
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — a68a7a6a Deployed Oct 13, 2026 by CQ880 via Generate label suggestions #55088
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants